Skip to content

Backport PR #19686 on branch v8.0.x (MNT: Ignore generated fast_converters.c) - #19688

Merged
pllim merged 1 commit into
astropy:v8.0.xfrom
meeseeksmachine:auto-backport-of-pr-19686-on-v8.0.x
May 6, 2026
Merged

pllim merged 1 commit into
astropy:v8.0.xfrom
meeseeksmachine:auto-backport-of-pr-19686-on-v8.0.x

Conversation

@meeseeksmachine

Copy link
Copy Markdown

Backport PR #19686: MNT: Ignore generated fast_converters.c

@lumberbot-app lumberbot-app Bot added this to the v8.0.0 milestone May 6, 2026
@lumberbot-app lumberbot-app Bot added io.votable Affects-dev PRs and issues that do not impact an existing Astropy release no-changelog-entry-needed backport-v8.0.x on-merge: backport to v8.0.x labels May 6, 2026
@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@pllim
pllim enabled auto-merge May 6, 2026 18:19
@pllim
pllim disabled auto-merge May 6, 2026 19:17
@pllim
pllim merged commit 685a9d0 into astropy:v8.0.x May 6, 2026
59 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Affects-dev PRs and issues that do not impact an existing Astropy release backport-v8.0.x on-merge: backport to v8.0.x io.votable no-changelog-entry-needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants