Skip to content

MNT: Ignore generated fast_converters.c - #19686

Merged
pllim merged 1 commit into
astropy:mainfrom
pllim:ignore-votable-gen-c
May 6, 2026
Merged

pllim merged 1 commit into
astropy:mainfrom
pllim:ignore-votable-gen-c

Conversation

@pllim

@pllim pllim commented May 6, 2026

Copy link
Copy Markdown
Member

Description

This pull request is to address untracked astropy/io/votable/src/fast_converters.c after building astropy locally that includes #18454 . Without this ignore, this generated file would be accidentally committed into version control in the future.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@pllim pllim added this to the v8.0.0 milestone May 6, 2026
@pllim
pllim requested review from bsipocz and stvoutsin May 6, 2026 17:59
@pllim
pllim requested a review from neutrinoceros as a code owner May 6, 2026 17:59
@pllim pllim added Affects-dev PRs and issues that do not impact an existing Astropy release no-changelog-entry-needed backport-v8.0.x on-merge: backport to v8.0.x labels May 6, 2026
@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@neutrinoceros
neutrinoceros enabled auto-merge May 6, 2026 18:01
@pllim

pllim commented May 6, 2026

Copy link
Copy Markdown
Member Author

No need to wait for doc. (I think we spamming RTD too much lately with the feature freeze frenzy so now it a bit wonky.)

@pllim
pllim disabled auto-merge May 6, 2026 18:16
@pllim
pllim merged commit 911ea0d into astropy:main May 6, 2026
52 of 55 checks passed
@pllim
pllim deleted the ignore-votable-gen-c branch May 6, 2026 18:16
pllim added a commit that referenced this pull request May 6, 2026
…686-on-v8.0.x

Backport PR #19686 on branch v8.0.x (MNT: Ignore generated fast_converters.c)
@pllim

pllim commented Jun 1, 2026

Copy link
Copy Markdown
Member Author

I am also going to backport this to v7.2.x for the following scenario:

  • have build files from later branches with this C file
  • switch to v7.2.x for some hot fix
  • git now say this file is untracked

@meeseeksdev backport to v7.2.x

pllim added a commit that referenced this pull request Jun 1, 2026
…686-on-v7.2.x

Backport PR #19686 on branch v7.2.x (MNT: Ignore generated fast_converters.c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Affects-dev PRs and issues that do not impact an existing Astropy release backport-v8.0.x on-merge: backport to v8.0.x io.votable no-changelog-entry-needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants