Repository navigation
MNT: Ignore generated fast_converters.c - #19686
Merged
Merged
Conversation
Contributor
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
1 task
neutrinoceros
approved these changes
May 6, 2026
neutrinoceros
enabled auto-merge
May 6, 2026 18:01
bsipocz
approved these changes
May 6, 2026
Member
Author
|
No need to wait for doc. (I think we spamming RTD too much lately with the feature freeze frenzy so now it a bit wonky.) |
pllim
disabled auto-merge
May 6, 2026 18:16
pllim
added a commit
that referenced
this pull request
May 6, 2026
pllim
added a commit
that referenced
this pull request
May 6, 2026
…686-on-v8.0.x Backport PR #19686 on branch v8.0.x (MNT: Ignore generated fast_converters.c)
Member
Author
|
I am also going to backport this to v7.2.x for the following scenario:
@meeseeksdev backport to v7.2.x |
pllim
added a commit
that referenced
this pull request
Jun 1, 2026
pllim
added a commit
that referenced
this pull request
Jun 1, 2026
…686-on-v7.2.x Backport PR #19686 on branch v7.2.x (MNT: Ignore generated fast_converters.c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request is to address untracked
astropy/io/votable/src/fast_converters.cafter buildingastropylocally that includes #18454 . Without this ignore, this generated file would be accidentally committed into version control in the future.