Skip to content

Remove redundant elif in fast_converters.pyx, fix RTD - #19664

Merged
pllim merged 2 commits into
astropy:mainfrom
pllim:pr18454-cleanup
May 5, 2026
Merged

pllim merged 2 commits into
astropy:mainfrom
pllim:pr18454-cleanup

Conversation

@pllim

@pllim pllim commented May 5, 2026 •

Copy link
Copy Markdown
Member

Description

This pull request is to address #18454 (comment) and #19571 (comment)

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@pllim pllim added this to the v8.0.0 milestone May 5, 2026
@pllim
pllim requested review from bsipocz and stvoutsin May 5, 2026 20:43
@pllim pllim added Affects-dev PRs and issues that do not impact an existing Astropy release no-changelog-entry-needed labels May 5, 2026
@github-actions

github-actions Bot commented May 5, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@pllim pllim added the units label May 5, 2026
@pllim pllim changed the title Remove redundant elif in fast_converters.pyx Remove redundant elif in fast_converters.pyx, fix RTD May 5, 2026
@pllim
pllim merged commit b231f8c into astropy:main May 5, 2026
46 checks passed
@pllim
pllim deleted the pr18454-cleanup branch May 5, 2026 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Affects-dev PRs and issues that do not impact an existing Astropy release io.votable no-changelog-entry-needed units

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants