Repository navigation
TST: fix portability issue with new serialization tests - #19634
neutrinoceros wants to merge 1 commit into
Conversation
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
9548a72 to
dcdcb72
Compare
dcdcb72 to
ad950ba
Compare
|
I was looking at this earlier (but didn't get to coding yet) and my thought was just use ellipsis in the doc output. But if this works, I guess it is better. Thanks! |
It doesn't, actually. I think this means it's a real bug, so we shouldn't hide it away with ellision either. |
|
Can you really force a int64 on a 32-bit emulator? |
|
Yes. It's just not used by default. I suspect this means we don't actually serialize data types correctly on any platform, but tests happen to work on all 64-bit archs |
|
Actually, my patch (or a variation of it, including deliberate use of non-native precisions) would probably be needed to test the correct solution any way, so I'll re-open as a draft. |
|
closing in favor or #19644 |
Description
Fixes #19632
follow up to #18703