Skip to content

TST: fix portability issue with new serialization tests - #19634

Closed
neutrinoceros wants to merge 1 commit into
astropy:mainfrom
neutrinoceros:tst/explicit-dtypes
Closed

neutrinoceros wants to merge 1 commit into
astropy:mainfrom
neutrinoceros:tst/explicit-dtypes

Conversation

@neutrinoceros

@neutrinoceros neutrinoceros commented May 1, 2026 •

Copy link
Copy Markdown
Contributor

Description

Fixes #19632
follow up to #18703

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@neutrinoceros neutrinoceros added this to the v8.0.0 milestone May 1, 2026
@neutrinoceros neutrinoceros added testing Affects-dev PRs and issues that do not impact an existing Astropy release no-changelog-entry-needed Extra CI Run cron CI as part of PR labels May 1, 2026
@github-actions

github-actions Bot commented May 1, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@neutrinoceros
neutrinoceros force-pushed the tst/explicit-dtypes branch from 9548a72 to dcdcb72 Compare May 1, 2026 16:50
@neutrinoceros
neutrinoceros force-pushed the tst/explicit-dtypes branch from dcdcb72 to ad950ba Compare May 1, 2026 17:09
@neutrinoceros
neutrinoceros marked this pull request as ready for review May 1, 2026 17:22
@neutrinoceros
neutrinoceros requested a review from taldcroft as a code owner May 1, 2026 17:22
@pllim

pllim commented May 1, 2026

Copy link
Copy Markdown
Member

I was looking at this earlier (but didn't get to coding yet) and my thought was just use ellipsis in the doc output. But if this works, I guess it is better. Thanks!

@neutrinoceros

Copy link
Copy Markdown
Contributor Author

But if this works, I guess it is better

It doesn't, actually. I think this means it's a real bug, so we shouldn't hide it away with ellision either.

@neutrinoceros
neutrinoceros deleted the tst/explicit-dtypes branch May 1, 2026 18:38
@pllim

pllim commented May 1, 2026

Copy link
Copy Markdown
Member

Can you really force a int64 on a 32-bit emulator?

@neutrinoceros

Copy link
Copy Markdown
Contributor Author

Yes. It's just not used by default. I suspect this means we don't actually serialize data types correctly on any platform, but tests happen to work on all 64-bit archs

@neutrinoceros

Copy link
Copy Markdown
Contributor Author

Actually, my patch (or a variation of it, including deliberate use of non-native precisions) would probably be needed to test the correct solution any way, so I'll re-open as a draft.

@neutrinoceros
neutrinoceros restored the tst/explicit-dtypes branch May 1, 2026 19:30
@neutrinoceros neutrinoceros reopened this May 1, 2026
@neutrinoceros
neutrinoceros marked this pull request as draft May 1, 2026 19:31
@neutrinoceros

Copy link
Copy Markdown
Contributor Author

closing in favor or #19644

@neutrinoceros
neutrinoceros deleted the tst/explicit-dtypes branch May 2, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Affects-dev PRs and issues that do not impact an existing Astropy release Bug Extra CI Run cron CI as part of PR no-changelog-entry-needed table testing unified-io

Projects

None yet

Development

Successfully merging this pull request may close these issues.

armv7 CI failures with recent serialization changes

2 participants