Repository navigation
Up Time's __array_priority__ to above Quantity's - #1940
Merged
Merged
Conversation
Member
|
Looks good to me. |
Member
|
Sorry @mhvk I should have merged this earlier but now it needs a rebase (presumably CHANGES.rst). While we're at it, do you think this is a bug fix for 0.3.1? It seems like that's the case, but can you think of any way this would change how things behave in any way so as to be an API change? |
Contributor
Author
|
OK, rebased (conflict was with my own PR, so can hardly complain!). I do think this qualifies as a bug-fix: before, the "wrong" order would have simply thrown an error (which is why the corresponding test was marked |
taldcroft
added a commit
that referenced
this pull request
Jan 5, 2014
Up Time's __array_priority__ to above Quantity's
Member
|
Same problem as #1925. |
taldcroft
added a commit
that referenced
this pull request
Feb 12, 2014
Up Time's __array_priority__ to above Quantity's Conflicts: CHANGES.rst
taldcroft
added a commit
that referenced
this pull request
Feb 12, 2014
Up Time's __array_priority__ to above Quantity's Conflicts: CHANGES.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TimeDeltashould have priority overQuantityso that constructions like(1.*u.m)/TimeDelta(100., format='sec')get handled correctly. With this, onexfailtest no longer fails.