Skip to content

Correct UT in calculation of TDB; closes #1938 - #1939

Merged
taldcroft merged 2 commits into
astropy:masterfrom
mhvk:time-correct-ut-in-tdb
Jan 3, 2014
Merged

Correct UT in calculation of TDB; closes #1938#1939
taldcroft merged 2 commits into
astropy:masterfrom
mhvk:time-correct-ut-in-tdb

Conversation

@mhvk

@mhvk mhvk commented Dec 31, 2013

Copy link
Copy Markdown
Contributor

Ensure UT is properly taken from midnight in the calculation of TDB. Use a slightly different approach from #1938, in using day_frac to get the time since midnight:

ut = day_frac(njd1 - 0.5, njd2)[1]

@mhvk mhvk mentioned this pull request Dec 31, 2013
Closed
@astrofrog

astrofrog commented Jan 2, 2014

Copy link
Copy Markdown
Member

@taldcroft - can you review this?

@taldcroft

taldcroft commented Jan 3, 2014

Copy link
Copy Markdown
Member

Looks good, merging.

taldcroft added a commit that referenced this pull request Jan 3, 2014
@taldcroft
Merge pull request #1939 from mhvk/time-correct-ut-in-tdb
cc1278a 
Correct UT in calculation of TDB; closes #1938
@taldcroft
taldcroft merged commit cc1278a into astropy:master Jan 3, 2014
@mhvk
mhvk deleted the time-correct-ut-in-tdb branch January 3, 2014 05:12
@mhvk

mhvk commented Jan 6, 2014

Copy link
Copy Markdown
Contributor Author

@taldcroft - while looking into @embray's comment that for #1925 and #1940 I messed up the location in CHANGES.rst (which I think you fixed already, right?), I noticed that this PR is scheduled for 0.4. Since it corrects an error in how TDB is calculated, I think this should have been 0.3.1. Is that still changeable? If so, this would also need a location change in CHANGES.rst...

@taldcroft

taldcroft commented Jan 6, 2014

Copy link
Copy Markdown
Member

@mhvk - I changed the milestone to 0.3.1 here. Was there a reason this was listed as an API Change instead of Bug Fix? That was probably the reason it got set to 0.4. I can move this to 0.3.1 bug fixes today if that's reasonable.

I didn't do any fixes to CHANGES.rst recently.

@embray

embray commented Jan 6, 2014

Copy link
Copy Markdown
Member

If this needs to be moved I can just make the change directly in the changelog.

@mhvk

mhvk commented Jan 6, 2014

Copy link
Copy Markdown
Contributor Author

@taldcroft - I must indeed have put the change in the wrong part of CHANGES.rst. @embray - if you could move it directly that would be great. Thanks, both.

taldcroft added a commit that referenced this pull request Feb 12, 2014
@taldcroft @embray
Merge pull request #1939 from mhvk/time-correct-ut-in-tdb
5cc59b9 
Correct UT in calculation of TDB; closes #1938
Conflicts:

	CHANGES.rst
taldcroft added a commit that referenced this pull request Feb 12, 2014
@taldcroft @embray
Merge pull request #1939 from mhvk/time-correct-ut-in-tdb
aefa99d 
Correct UT in calculation of TDB; closes #1938
Conflicts:

	CHANGES.rst
@mhvk mhvk mentioned this pull request May 2, 2014
Closed
1 of 2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

time

Projects

None yet

Milestone

v0.3.1

Development

Successfully merging this pull request may close these issues.

4 participants

@mhvk @astrofrog @taldcroft @embray