Skip to content

Handle chararray deprecation - #19335

Merged
pllim merged 2 commits into
astropy:v7.2.xfrom
saimn:backport-19267
Feb 26, 2026
Merged

pllim merged 2 commits into
astropy:v7.2.xfrom
saimn:backport-19267

Conversation

@saimn

@saimn saimn commented Feb 26, 2026 •

Copy link
Copy Markdown
Contributor

Manual backport for #19267, removing the deprecation warnings and use of np.strings.

Description

This pull request is to close #19216

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@saimn saimn added this to the v7.2.1 milestone Feb 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@saimn saimn added the skip-basebranch-check Skip base branch check for direct backports label Feb 26, 2026
@saimn saimn closed this Feb 26, 2026
@saimn saimn reopened this Feb 26, 2026
@saimn

saimn commented Feb 26, 2026

Copy link
Copy Markdown
Contributor Author

Hmm not sure why the py311 job is failing with No module named 'numpy.char' ...

@pllim

pllim commented Feb 26, 2026

Copy link
Copy Markdown
Member

That is the oldestdeps job. It is grabbing numpy==1.24.0

@pllim

pllim commented Feb 26, 2026

Copy link
Copy Markdown
Member

I think it has to be like this:

>>> from numpy import char
>>> char.array
<function numpy.char.array(obj, itemsize=None, copy=True, unicode=None, order=None)>

@saimn

saimn commented Feb 26, 2026 •

Copy link
Copy Markdown
Contributor Author

Actually seems importing from numpy.char never worked with numpy 1.x : numpy/numpy#27135 (comment)

@pllim pllim added the Extra CI Run cron CI as part of PR label Feb 26, 2026
@pllim

pllim commented Feb 26, 2026

Copy link
Copy Markdown
Member

Yay, finally green devdeps. Thanks! I will approve when the optional CIs finish running.

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!!!

@pllim
pllim merged commit 300a802 into astropy:v7.2.x Feb 26, 2026
46 of 47 checks passed
@saimn
saimn deleted the backport-19267 branch February 27, 2026 07:24
tonybaloney pushed a commit to tonybaloney/swe-complex-astropy that referenced this pull request Mar 19, 2026
tonybaloney pushed a commit to tonybaloney/swe-complex-astropy that referenced this pull request Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Extra CI Run cron CI as part of PR io.fits skip-basebranch-check Skip base branch check for direct backports utils

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants