Repository navigation
Handle chararray deprecation - #19335
Merged
Merged
Conversation
Contributor
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
saimn
force-pushed
the
backport-19267
branch
from
February 26, 2026 13:23
0301801 to
5ccac88
Compare
Contributor
Author
|
Hmm not sure why the py311 job is failing with |
Member
|
That is the oldestdeps job. It is grabbing |
Member
|
I think it has to be like this: >>> from numpy import char
>>> char.array
<function numpy.char.array(obj, itemsize=None, copy=True, unicode=None, order=None)> |
Contributor
Author
|
Actually seems importing from |
Member
|
Yay, finally green devdeps. Thanks! I will approve when the optional CIs finish running. |
tonybaloney
pushed a commit
to tonybaloney/swe-complex-astropy
that referenced
this pull request
Mar 19, 2026
PR: astropy#19335 Issue: astropy#19216 Base commit: fc0ebad Changed lines: 55
tonybaloney
pushed a commit
to tonybaloney/swe-complex-astropy
that referenced
this pull request
Mar 19, 2026
PR: astropy#19335 Issue: astropy#19216 Base commit: fc0ebad Changed lines: 55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport for #19267, removing the deprecation warnings and use of
np.strings.Description
This pull request is to close #19216