Skip to content

Temporarily ignore chararray DeprecationWarning - #19303

Closed
pllim wants to merge 1 commit into
astropy:mainfrom
pllim:ignore-chararray-depre-try2
Closed

Temporarily ignore chararray DeprecationWarning#19303
pllim wants to merge 1 commit into
astropy:mainfrom
pllim:ignore-chararray-depre-try2

Conversation

@pllim

@pllim pllim commented Feb 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Description

This pull request is to temporarily works around #19216 until #3862 and other related issues/PRs can be resolved. They seem to take a slower timescale because FITS is a complicated beast that is widely used.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@pllim pllim added this to the v7.2.1 milestone Feb 13, 2026
@github-actions

github-actions Bot commented Feb 13, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@pllim

This comment was marked as resolved.

Sign in to view
@pllim
Temporarily ignore chararray DeprecationWarning
306a8e2 
that happens on import from numpy 2.5.dev
because we turn warning into exception and this is blocking meaningful devdeps run for others.
@pllim
pllim force-pushed the ignore-chararray-depre-try2 branch from e0a31ef to 306a8e2 Compare February 13, 2026 16:54
@pllim
pllim marked this pull request as ready for review February 13, 2026 17:54
@pllim
pllim requested a review from saimn as a code owner February 13, 2026 17:54
@pllim
pllim requested review from mhvk and neutrinoceros February 13, 2026 17:54
@pllim pllim mentioned this pull request Feb 13, 2026
Closed
neutrinoceros
neutrinoceros approved these changes Feb 13, 2026
View reviewed changes

@neutrinoceros neutrinoceros left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I implied on the issue I'm not a fan of this approach but provided @saimn is okay with it I'm on board.

mhvk
mhvk approved these changes Feb 14, 2026
View reviewed changes

@mhvk mhvk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, makes sense to "buy some time" to figure out the best path forward (and in the meantime have a working -dev...)

@saimn

saimn commented Feb 16, 2026

Copy link
Copy Markdown
Contributor

I thought #19267 would solve the issue for main ? Then we can imagine a simplified version (just filtering the warning from Numpy) for 7.2.x, but would be better if the code was closer to #19267 (e..g filtering the warning in utils.compat and keeping the same imports) to minimize the potential conflicts when backporting.

@pllim

pllim commented Feb 18, 2026

Copy link
Copy Markdown
Member Author

I am just not sure how much more time #19267 needs. So should I close this PR without merge or move the ignore as you suggested? Please advise. Thanks!

@saimn

saimn commented Feb 18, 2026

Copy link
Copy Markdown
Contributor

I think we could merge #19267 to fix -dev and deal with strip_spaces for Table in a follow up PR once we agree on a way forward.

@pllim pllim closed this Feb 18, 2026
@pllim
pllim deleted the ignore-chararray-depre-try2 branch February 18, 2026 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhvk mhvk mhvk approved these changes
@neutrinoceros neutrinoceros neutrinoceros approved these changes
@saimn saimn Awaiting requested review from saimn saimn is a code owner

Assignees

No one assigned

Labels

backport-v7.2.x on-merge: backport to v7.2.x io.fits no-changelog-entry-needed numpy-dev

Projects

None yet

Milestone

v7.2.1

Development

Successfully merging this pull request may close these issues.

4 participants

@pllim @saimn @mhvk @neutrinoceros