Skip to content

pre-commit manual update (redo of PR 19250) - #19259

Merged
pllim merged 1 commit into
astropy:mainfrom
pllim:precommit-updates
Feb 3, 2026
Merged

pre-commit manual update (redo of PR 19250)#19259
pllim merged 1 commit into
astropy:mainfrom
pllim:precommit-updates

Conversation

@pllim

@pllim pllim commented Feb 3, 2026

Copy link
Copy Markdown
Member

Description

This pull request is to address failed auto-update (#19250) because we have to manually ignore a new rule.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@pllim
pre-commit manual update
37aa420 
and ignore new rule to pass check
@pllim pllim added this to the v8.0.0 milestone Feb 3, 2026
@github-actions

github-actions Bot commented Feb 3, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@pllim
pllim marked this pull request as ready for review February 3, 2026 18:43
nstarman
nstarman reviewed Feb 3, 2026
View reviewed changes
Comment thread pyproject.toml

@nstarman nstarman Feb 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neutrinoceros, just wanted to confirm that this is compatible with the PR you're working on. The plan is to remove this ignore as part of that PR?

@pllim pllim Feb 3, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a competing PR? If so, I apologize as I was not aware. Which one is it?

@nstarman nstarman Feb 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#18342

@pllim pllim Feb 3, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, PR 18342 should remove the ignore added here.

@neutrinoceros neutrinoceros Feb 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the ping. And done

@pllim
pllim merged commit 78fdb6c into astropy:main Feb 3, 2026
34 of 35 checks passed
@pllim
pllim deleted the precommit-updates branch February 3, 2026 21:13
@pllim

pllim commented Feb 3, 2026

Copy link
Copy Markdown
Member Author

Thanks for the review!

@pllim pllim mentioned this pull request Feb 3, 2026
Merged
1 of 2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nstarman nstarman nstarman approved these changes
@WilliamJamieson WilliamJamieson Awaiting requested review from WilliamJamieson WilliamJamieson is a code owner
@neutrinoceros neutrinoceros Awaiting requested review from neutrinoceros neutrinoceros is a code owner

Assignees

No one assigned

Labels

dev-automation installation no-changelog-entry-needed skip-changelog-checks Tells bot to skip changlog checks testing

Projects

None yet

Milestone

v8.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@pllim @nstarman @neutrinoceros