Attempt to calculate delta_ut1_utc when the attribute is accessed directly #1925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astropy/time/core.py
Outdated
Member
There was a problem hiding this comment.
This somehow breaks the symmetry in a weird way. What about leaving both the defaults at None and then doing:
if jd1 is None and jd2 is None:
utc = self.utc
jd1 = utc.jd1
jd2 = utc.jd2
else:
if jd1 is None:
jd1 = 0.0
if jd2 is None:
jd2 = 0.0
Member
|
@mhvk - looks good. I marked this as 0.3.1 and we can call it a bug fix. Can you update CHANGES.rst accordingly? |
Contributor
Author
|
@taldcroft - OK, |
taldcroft
added a commit
that referenced
this pull request
Jan 4, 2014
Attempt to calculate delta_ut1_utc when the attribute is accessed directly
Member
|
This was added to the 0.4 section of the changelog but is in the 0.3.1 milestone. I'm not sure which was the intent. |
taldcroft
added a commit
that referenced
this pull request
Feb 12, 2014
Attempt to calculate delta_ut1_utc when the attribute is accessed directly Conflicts: CHANGES.rst
taldcroft
added a commit
that referenced
this pull request
Feb 12, 2014
Attempt to calculate delta_ut1_utc when the attribute is accessed directly Conflicts: CHANGES.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A partial answer to the bugs reported in #1924. Now:
yields
instead of giving a rather obscure error message