Skip to content

EXP: define our own chararray class - #19241

Closed
neutrinoceros wants to merge 4 commits into
astropy:mainfrom
neutrinoceros:compat/astropy_chararray
Closed

EXP: define our own chararray class#19241
neutrinoceros wants to merge 4 commits into
astropy:mainfrom
neutrinoceros:compat/astropy_chararray

Conversation

@neutrinoceros

@neutrinoceros neutrinoceros commented Jan 31, 2026

Copy link
Copy Markdown
Contributor

Description

Based off #19217, tentatively address #3862
At the time of opening, I'm only trying to port the class straight from numpy and see if this survives testing, in particular against numpy dev. If it does, then the end goal will be to reduce the class as much as possible and deprecate it on our own schedule.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@neutrinoceros neutrinoceros added this to the v8.0.0 milestone Jan 31, 2026
@github-actions

github-actions Bot commented Jan 31, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@neutrinoceros

neutrinoceros commented Feb 2, 2026

Copy link
Copy Markdown
Contributor Author 
    def __eq__(self, other):
        """
        Return (self == other) element-wise.
    
        See Also
        --------
        equal
        """
>       return np.strings.equal(self, other)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
E       numpy._core._exceptions._UFuncNoLoopError: ufunc 'equal' did not contain a loop with signature matching types (<class 'numpy.dtypes.StrDType'>, <class 'numpy.dtypes.BytesDType'>) -> None

This was referenced Feb 4, 2026
Closed
Merged
@neutrinoceros

neutrinoceros commented Feb 4, 2026

Copy link
Copy Markdown
Contributor Author

closing in favor of #19267

@neutrinoceros
neutrinoceros deleted the compat/astropy_chararray branch February 4, 2026 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saimn saimn Awaiting requested review from saimn saimn will be requested when the pull request is marked ready for review saimn is a code owner

Assignees

No one assigned

Labels

Experimental io.fits numpy-dev utils

Projects

None yet

Milestone

v8.0.0

Development

Successfully merging this pull request may close these issues.

1 participant

@neutrinoceros