Repository navigation
DEP: set upper bound on numpy requirement (7.2.x) - #19233
Conversation
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
|
failures on oldestdeps are extremely confusing. Trying to remove the warning filter and see where things go. |
351e3ed to
4b995a3
Compare
0fe7df6 to
6a54892
Compare
6a54892 to
eaad34b
Compare
eaad34b to
5dfe0cc
Compare
|
seems like we still need to add version-dependent pathes in tests for the backport branch. Working on it. |
|
looks like none of it is trivial, unfortunately, so to avoid further delays, I'll undraft this now: it is already solving the problem it is aimed to resolve, but I can't promise that other problems will be solved too at the moment. |
mhvk
left a comment
There was a problem hiding this comment.
This looks OK to me. An upper limit to numpy seems reasonable, especially since it still includes 2.5 and 2.6, which are still to be released.
| ] | ||
| dependencies = [ | ||
| "numpy>=1.24", | ||
| "numpy>=1.24, <2.7", |
There was a problem hiding this comment.
Given v7.2 is "LTS lite", would this max pin be acceptable, @astropy/astropy-project-release-team ?
|
@pllim - Fine with me. |
pllim
left a comment
There was a problem hiding this comment.
OK let's merge before follow-up
Description
Replace #19229