Skip to content

DEP: set upper bound on numpy requirement (7.2.x) - #19233

Merged
pllim merged 2 commits into
astropy:v7.2.xfrom
neutrinoceros:dep/upper-bound-numpy-2.7
Feb 23, 2026
Merged

pllim merged 2 commits into
astropy:v7.2.xfrom
neutrinoceros:dep/upper-bound-numpy-2.7

Conversation

@neutrinoceros

Copy link
Copy Markdown
Contributor

Description

Replace #19229

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@neutrinoceros

Copy link
Copy Markdown
Contributor Author

failures on oldestdeps are extremely confusing. Trying to remove the warning filter and see where things go.

@neutrinoceros
neutrinoceros force-pushed the dep/upper-bound-numpy-2.7 branch from 351e3ed to 4b995a3 Compare January 28, 2026 10:27
@neutrinoceros
neutrinoceros force-pushed the dep/upper-bound-numpy-2.7 branch from eaad34b to 5dfe0cc Compare January 28, 2026 13:30
@neutrinoceros

Copy link
Copy Markdown
Contributor Author

seems like we still need to add version-dependent pathes in tests for the backport branch. Working on it.

@neutrinoceros

Copy link
Copy Markdown
Contributor Author

looks like none of it is trivial, unfortunately, so to avoid further delays, I'll undraft this now: it is already solving the problem it is aimed to resolve, but I can't promise that other problems will be solved too at the moment.

@neutrinoceros
neutrinoceros marked this pull request as ready for review January 28, 2026 14:42

@mhvk mhvk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK to me. An upper limit to numpy seems reasonable, especially since it still includes 2.5 and 2.6, which are still to be released.

Comment thread pyproject.toml
]
dependencies = [
"numpy>=1.24",
"numpy>=1.24, <2.7",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given v7.2 is "LTS lite", would this max pin be acceptable, @astropy/astropy-project-release-team ?

@pllim
pllim requested a review from a team January 28, 2026 15:34
@neutrinoceros neutrinoceros mentioned this pull request Feb 4, 2026
1 task
@pllim

pllim commented Feb 20, 2026

Copy link
Copy Markdown
Member

@saimn , are we merging this first before kinda-backporting #19267 ?

@saimn

saimn commented Feb 23, 2026

Copy link
Copy Markdown
Contributor

@pllim - Fine with me.

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK let's merge before follow-up

@pllim
pllim merged commit 5f3df3e into astropy:v7.2.x Feb 23, 2026
32 of 33 checks passed
@neutrinoceros
neutrinoceros deleted the dep/upper-bound-numpy-2.7 branch February 23, 2026 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants