Skip to content

Backport PR #19227 on branch v7.2.x (RFC: Replace np.char.decode with np.strings.decode) - #19229

Closed
meeseeksmachine wants to merge 1 commit into
astropy:v7.2.xfrom
meeseeksmachine:auto-backport-of-pr-19227-on-v7.2.x
Closed

meeseeksmachine wants to merge 1 commit into
astropy:v7.2.xfrom
meeseeksmachine:auto-backport-of-pr-19227-on-v7.2.x

Conversation

@meeseeksmachine

Copy link
Copy Markdown

Backport PR #19227: RFC: Replace np.char.decode with np.strings.decode

@lumberbot-app lumberbot-app Bot added this to the v7.2.1 milestone Jan 27, 2026
@lumberbot-app lumberbot-app Bot added Affects-dev PRs and issues that do not impact an existing Astropy release no-changelog-entry-needed numpy-dev backport-v7.2.x on-merge: backport to v7.2.x labels Jan 27, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@mhvk

mhvk commented Jan 27, 2026

Copy link
Copy Markdown
Contributor

@pllim - I don't quite recall when np.strings was introduced, but fear this may fail here since we still support numpy < 2... If so, I'd suggest to just silence the deprecation warning rather than introduce numpy-version specific paths.

neutrinoceros
neutrinoceros previously approved these changes Jan 28, 2026
@neutrinoceros

Copy link
Copy Markdown
Contributor

Whoops, approved prematurely...
numpy.strings was indeed not available until version 2.0, so I agree this backport isn't viable. Maybe we should also add an upper bound on numpy for the backport branch too

@neutrinoceros

Copy link
Copy Markdown
Contributor

superseded by #19233

@pllim

pllim commented Jan 28, 2026

Copy link
Copy Markdown
Member

Thanks, all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Affects-dev PRs and issues that do not impact an existing Astropy release backport-v7.2.x on-merge: backport to v7.2.x io.fits no-changelog-entry-needed numpy-dev table

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants