Skip to content

BUG: a avoid deprecation warning from numpy.char.chararray (table) - #19218

Merged
taldcroft merged 1 commit into
astropy:mainfrom
neutrinoceros:table/compat/chararray_decode
Jan 26, 2026
Merged

BUG: a avoid deprecation warning from numpy.char.chararray (table)#19218
taldcroft merged 1 commit into
astropy:mainfrom
neutrinoceros:table/compat/chararray_decode

Conversation

@neutrinoceros

@neutrinoceros neutrinoceros commented Jan 26, 2026

Copy link
Copy Markdown
Contributor

Description

ref #19216

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@neutrinoceros neutrinoceros added this to the v7.2.1 milestone Jan 26, 2026
@github-actions

github-actions Bot commented Jan 26, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions github-actions Bot added the table label Jan 26, 2026
@neutrinoceros neutrinoceros mentioned this pull request Jan 26, 2026
Closed
@neutrinoceros
neutrinoceros marked this pull request as ready for review January 26, 2026 10:41
taldcroft
taldcroft approved these changes Jan 26, 2026
View reviewed changes

@taldcroft taldcroft left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@taldcroft
taldcroft merged commit 9060569 into astropy:main Jan 26, 2026
47 of 48 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Jan 26, 2026
@neutrinoceros @meeseeksmachine
Backport PR astropy#19218: BUG: a avoid deprecation warning from nump…
bb6d39b 
…y.char.chararray (table)
@meeseeksmachine meeseeksmachine mentioned this pull request Jan 26, 2026
Merged
@neutrinoceros
neutrinoceros deleted the table/compat/chararray_decode branch January 26, 2026 15:11
saimn
saimn reviewed Jan 26, 2026
View reviewed changes
Comment thread astropy/table/column.py
def tolist(self):
if self.dtype.kind == "S":
return np.char.chararray.decode(self, encoding="utf-8").tolist()
return np.char.decode(self, encoding="utf-8").tolist()

@saimn saimn Jan 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would probably have been better to use np.strings.decode right away.

@pllim pllim Jan 26, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saimn do we need a follow-up PR to use np.strings?

@saimn saimn Jan 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be done when np.char is deprecated but might as well do it now.

@neutrinoceros neutrinoceros Jan 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can certainly open a new ticket to follow up on #19126, specifically about ridding astropy of all remaining use cases of np.char, though it's not perfectly clear to me whether it'll actually go away in the future:

This submodule is considered legacy and will no longer receive updates. This could also mean it will be removed in future NumPy versions.

(notice the use of conditional)

@pllim pllim Jan 27, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #19227

@pllim pllim mentioned this pull request Jan 27, 2026
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saimn saimn saimn left review comments
@pllim pllim pllim left review comments
@taldcroft taldcroft taldcroft approved these changes

Assignees

No one assigned

Labels

backport-v7.2.x on-merge: backport to v7.2.x Bug no-changelog-entry-needed numpy-dev table

Projects

None yet

Milestone

v7.2.1

Development

Successfully merging this pull request may close these issues.

4 participants

@neutrinoceros @saimn @taldcroft @pllim