Skip to content

BUG: avoid deprecated shape mutation APIs in coordinates (2) - #19187

Merged
pllim merged 1 commit into
astropy:mainfrom
neutrinoceros:coordinates/19126-2
Jan 21, 2026
Merged

pllim merged 1 commit into
astropy:mainfrom
neutrinoceros:coordinates/19126-2

Conversation

@neutrinoceros

Copy link
Copy Markdown
Contributor

Description

ref #19126
follow up to #19127
ported from #19184

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@neutrinoceros

Copy link
Copy Markdown
Contributor Author

failures are unrelated but worrisome: we now have 3 failing jobs, one of which is required for any merger

@neutrinoceros
neutrinoceros marked this pull request as ready for review January 20, 2026 13:06
@pllim
pllim requested a review from mhvk January 20, 2026 15:39
@pllim

pllim commented Jan 20, 2026

Copy link
Copy Markdown
Member

Only RTD is blocking and of course it has to fail over a long holiday weekend in USA.

@mhvk mhvk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, makes sense.

@pllim
pllim force-pushed the coordinates/19126-2 branch from e7979d5 to e76b9f4 Compare January 21, 2026 21:44
@pllim
pllim merged commit 143c9c1 into astropy:main Jan 21, 2026
30 of 31 checks passed
@pllim

pllim commented Jan 21, 2026

Copy link
Copy Markdown
Member

Thanks! 35 failures left...

@neutrinoceros

Copy link
Copy Markdown
Contributor Author

35 failures left...

33 of these are from jplephem, alsready being worked on upstream. The other 2 are from time, which we're also discussing already. Bottom line is: we're getting there.

@neutrinoceros
neutrinoceros deleted the coordinates/19126-2 branch January 21, 2026 22:47
pllim added a commit that referenced this pull request Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants