Skip to content

Backport PR 19158 to branch v7.2.x (BUG/TST: avoid (or accept) NumPy deprecation warnings for mutating shape attributes in utils.masked) - #19183

Merged
pllim merged 1 commit into
astropy:v7.2.xfrom
neutrinoceros:bp/19158
Jan 20, 2026
Merged

Backport PR 19158 to branch v7.2.x (BUG/TST: avoid (or accept) NumPy deprecation warnings for mutating shape attributes in utils.masked)#19183
pllim merged 1 commit into
astropy:v7.2.xfrom
neutrinoceros:bp/19158

Conversation

@neutrinoceros

@neutrinoceros neutrinoceros commented Jan 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Manual backport for #19158

(cherry picked from commit 7cc5a2c)

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@mhvk @neutrinoceros
Merge pull request astropy#19158 from neutrinoceros/utils.masked/19126
d8ee750 
BUG/TST: avoid (or accept) NumPy deprecation warnings for mutating shape attributes in utils.masked

(cherry picked from commit 7cc5a2c)
@neutrinoceros neutrinoceros added this to the v7.2.1 milestone Jan 19, 2026
@github-actions

github-actions Bot commented Jan 19, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@neutrinoceros neutrinoceros changed the title Backport PR 19158 to branch v7.2.x ( Backport PR 19158 to branch v7.2.x (BUG/TST: avoid (or accept) NumPy deprecation warnings for mutating shape attributes in utils.masked) Jan 19, 2026
@neutrinoceros neutrinoceros mentioned this pull request Jan 19, 2026
Merged
1 task
@neutrinoceros
neutrinoceros marked this pull request as ready for review January 19, 2026 15:55
pllim
pllim approved these changes Jan 20, 2026
View reviewed changes

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pllim

pllim commented Jan 20, 2026

Copy link
Copy Markdown
Member

The failures are not related.

@pllim
pllim merged commit 24b5da0 into astropy:v7.2.x Jan 20, 2026
39 of 43 checks passed
@neutrinoceros
neutrinoceros deleted the bp/19158 branch January 20, 2026 15:24
tonybaloney pushed a commit to tonybaloney/swe-complex-astropy that referenced this pull request Mar 19, 2026
SWE-bench Complex Anthony Shaw
Human gold patch for astropy__astropy-19183
202d923 
PR: astropy#19183
Issue: astropy#19158
Base commit: ad43dc7
Changed lines: 26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pllim pllim pllim approved these changes

Assignees

No one assigned

Labels

Manual Backport no-changelog-entry-needed numpy-dev skip-basebranch-check Skip base branch check for direct backports utils.masked

Projects

None yet

Milestone

v7.2.1

Development

Successfully merging this pull request may close these issues.

3 participants

@neutrinoceros @pllim @mhvk