Skip to content

BUG/TST: avoid (or accept) NumPy deprecation warnings for mutating shape attributes in utils.masked - #19158

Merged
mhvk merged 2 commits into
astropy:mainfrom
neutrinoceros:utils.masked/19126
Jan 19, 2026
Merged

mhvk merged 2 commits into
astropy:mainfrom
neutrinoceros:utils.masked/19126

Conversation

@neutrinoceros

@neutrinoceros neutrinoceros commented Jan 14, 2026 •

Copy link
Copy Markdown
Contributor

Description

ref #19126

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@neutrinoceros

Copy link
Copy Markdown
Contributor Author

this resolve 7 out of the 9 remaining failures
ping @pllim @mhvk

@mhvk mhvk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super! Let's get these in...

@mhvk
mhvk merged commit 7cc5a2c into astropy:main Jan 19, 2026
29 of 31 checks passed
@lumberbot-app

lumberbot-app Bot commented Jan 19, 2026

Copy link
Copy Markdown

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v7.2.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 7cc5a2c0c7bb0fd0ecf89bbf12315184c89a4d94
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #19158: BUG/TST: avoid (or accept) NumPy deprecation warnings for mutating shape attributes in utils.masked'
  1. Push to a named branch:
git push YOURFORK v7.2.x:auto-backport-of-pr-19158-on-v7.2.x
  1. Create a PR against branch v7.2.x, I would have named this PR:

"Backport PR #19158 on branch v7.2.x (BUG/TST: avoid (or accept) NumPy deprecation warnings for mutating shape attributes in utils.masked)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@neutrinoceros
neutrinoceros deleted the utils.masked/19126 branch January 19, 2026 15:48
neutrinoceros pushed a commit to neutrinoceros/astropy that referenced this pull request Jan 19, 2026
BUG/TST: avoid (or accept) NumPy deprecation warnings for mutating shape attributes in utils.masked

(cherry picked from commit 7cc5a2c)
@neutrinoceros

Copy link
Copy Markdown
Contributor Author

manual backport at #19183

tonybaloney pushed a commit to tonybaloney/swe-complex-astropy that referenced this pull request Mar 19, 2026
tonybaloney pushed a commit to tonybaloney/swe-complex-astropy that referenced this pull request Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants