Skip to content

DOC: Remove unnecessary doctest-skip - #19136

Merged
neutrinoceros merged 1 commit into
astropy:mainfrom
pllim:fix-rtd-doctestplus
Jan 8, 2026
Merged

neutrinoceros merged 1 commit into
astropy:mainfrom
pllim:fix-rtd-doctestplus

Conversation

@pllim

@pllim pllim commented Jan 8, 2026

Copy link
Copy Markdown
Member

from new fitter doc

Description

This pull request is to close #19134

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@pllim pllim added this to the v7.2.1 milestone Jan 8, 2026
@github-actions

github-actions Bot commented Jan 8, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@pllim
pllim marked this pull request as ready for review January 8, 2026 18:29
@pllim
pllim requested a review from a team as a code owner January 8, 2026 18:29
@pllim
pllim requested a review from neutrinoceros January 8, 2026 18:29

@neutrinoceros neutrinoceros left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !

@neutrinoceros
neutrinoceros merged commit a7be681 into astropy:main Jan 8, 2026
47 of 48 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Jan 8, 2026
@pllim
pllim deleted the fix-rtd-doctestplus branch January 8, 2026 20:51
pllim added a commit that referenced this pull request Jan 8, 2026
…136-on-v7.2.x

Backport PR #19136 on branch v7.2.x (DOC: Remove unnecessary doctest-skip)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DOC: docs builds are failing (new warning from pytest-doctestplus 1.7.0)

2 participants