Skip to content

Angle to string avoid older numpy warning - #19021

Closed
mhvk wants to merge 8 commits into
astropy:mainfrom
mhvk:angle-to-string-avoid-older-numpy-warning
Closed

Angle to string avoid older numpy warning#19021
mhvk wants to merge 8 commits into
astropy:mainfrom
mhvk:angle-to-string-avoid-older-numpy-warning

Conversation

@mhvk

@mhvk mhvk commented Dec 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

This pull request is to address a very minor problem, of getting a RuntimeError from Angle.to_string() on older numpy combined with older python (and apparently only if installed in the way our CI does it; @pllim cannot reproduce it). It basically avoids using np.vectorize and instead explicitly iterates. Not elegant, but it works.

Note that this is on top of #18986 only because with that PR, the problem is shown in oldestdeps -- one gets the same warning on main, but this is not caught on CI as relevant combination is not tested. I made it draft for that reason; for now, only look at the last commit.

In principle, we could take this opportunity to use the new string type ("T") introduced in numpy 2.0, which would be better for performance and memory usage, but I think that is better done as a more general overhaul.

EDIT: p.s. Perhaps needs discussion on whether this should be backported.

Fixes #18989

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@mhvk mhvk added this to the v8.0.0 milestone Dec 3, 2025
@github-actions

github-actions Bot commented Dec 3, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@mhvk mhvk removed the testing label Dec 3, 2025
@mhvk mhvk mentioned this pull request Dec 3, 2025
Merged
1 task done
pllim
pllim reviewed Dec 8, 2025
View reviewed changes
Comment thread pyproject.toml
"error",
# https://github.com/astropy/astropy/issues/18126
"ignore:'_UnionGenericAlias' is deprecated and slated for removal in Python 3.17:DeprecationWarning", # not PYTHON_LT_3_14
# Weird warning from the vectorized do_format in Angle.to_string. low numpy/python?

@pllim pllim Dec 8, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Weird warning from the vectorized do_format in Angle.to_string. low numpy/python?

@github-actions github-actions Bot added the Close? Tell stale bot that this issue/PR is stale label May 3, 2026
@github-actions

github-actions Bot commented May 3, 2026

Copy link
Copy Markdown
Contributor

Hi humans 👋 - this pull request hasn't had any new commits for approximately 4 months. I plan to close this in 30 days if the pull request doesn't have any new commits by then.

In lieu of a stalled pull request, please consider closing this and open an issue instead if a reminder is needed to revisit in the future. Maintainers may also choose to add keep-open label to keep this PR open but it is discouraged unless absolutely necessary.

If this PR still needs to be reviewed, as an author, you can rebase it to reset the clock.

If you believe I commented on this pull request incorrectly, please report this here.

@astrofrog astrofrog modified the milestones: v8.0.0, v8.1.0 May 5, 2026
@github-actions github-actions Bot added the closed-by-bot Closed by stale bot label Jun 2, 2026
@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

I'm going to close this pull request as per my previous message. If you think what is being added/fixed here is still important, please remember to open an issue to keep track of it. Thanks!

If this is the first time I am commenting on this issue, or if you believe I closed this issue incorrectly, please report this here.

@github-actions github-actions Bot closed this Jun 2, 2026
@github-project-automation github-project-automation Bot moved this from Triage to Done in Cosmology, the Expansion Jun 2, 2026
@mhvk
mhvk deleted the angle-to-string-avoid-older-numpy-warning branch August 24, 2026 20:25
This was referenced Oct 15, 2026
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pllim pllim pllim left review comments
@neutrinoceros neutrinoceros Awaiting requested review from neutrinoceros neutrinoceros will be requested when the pull request is marked ready for review neutrinoceros is a code owner
@taldcroft taldcroft Awaiting requested review from taldcroft taldcroft will be requested when the pull request is marked ready for review taldcroft is a code owner
@larrybradley larrybradley Awaiting requested review from larrybradley larrybradley will be requested when the pull request is marked ready for review larrybradley is a code owner
@WilliamJamieson WilliamJamieson Awaiting requested review from WilliamJamieson WilliamJamieson will be requested when the pull request is marked ready for review WilliamJamieson is a code owner
@matteobachetti matteobachetti Awaiting requested review from matteobachetti matteobachetti will be requested when the pull request is marked ready for review matteobachetti is a code owner
@saimn saimn Awaiting requested review from saimn saimn will be requested when the pull request is marked ready for review saimn is a code owner

Assignees

No one assigned

Labels

Close? Tell stale bot that this issue/PR is stale closed-by-bot Closed by stale bot coordinates no-changelog-entry-needed Refactoring

Projects

Cosmology, the Expansion
Status: Done

Milestone

v8.1.0

Development

Successfully merging this pull request may close these issues.

Runtime error from Angle.to_string() on older python/numpy combinations

3 participants

@mhvk @pllim @astrofrog