Repository navigation
Conversation
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
|
👋 Thank you for your draft pull request! Do you know that you can use |
d8e0bf3 to
99abec6
Compare
|
Thank you @stvoutsin, I totally missed this! I'm adding xref to ivoa-std/VOTable#71; and also adding the |
99abec6 to
54ff4e4
Compare
54ff4e4 to
f29600f
Compare
c1badc4 to
27200c7
Compare
|
Hi humans 👋 - this pull request hasn't had any new commits for approximately 5 months. I plan to close this in a month if the pull request doesn't have any new commits by then. In lieu of a stalled pull request, please consider closing this and open an issue instead if a reminder is needed to revisit in the future. If this PR still needs to be reviewed, as an author, you can rebase it to reset the clock. If you believe I commented on this pull request incorrectly, please report this here. |
|
ping @stvoutsin - could you rebase so the stale bot goes away. And anyways, we're close to feature freeze and I believe the consensus was to try to get all the votable 1.6 relevant stuff in this release, if possible. |
27200c7 to
4a7185e
Compare
4a7185e to
1fee22a
Compare
|
I've spotted a few issues after looking at the latest version of the VOTable 1.6 text. I will update accordingly |
Description
This PR is a draft with a purpose of showing one possible implementation of adding VOTable 1.6 UTF-8 character encoding support in the
Charconverter. VOTable 1.6 changed thechardatatype semantics:arraysizenow specifies byte length (not character count) and explicitly supports UTF-8 encoding.PR'ing this early for visibility and iteration, looking for feedback on design decisions and current version.
Changes
Charconverter to detect VOTable 1.6+ viaversion_1_6_or_laterconfig flagformat="O") for UTF-8 fields_binparse_fixed,_binoutput_fixed)_binoutput_fixedto prevent incomplete multi-byte sequencesFixes #18515