Repository navigation
EXP: revert #18164 - #18971
EXP: revert #18164#18971neutrinoceros wants to merge 8 commits into
Conversation
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
|
👋 Thank you for your draft pull request! Do you know that you can use |
|
If you wanted to know what went wrong with 8aa1dd2 then you could have just tested that commit directly. |
|
Adjustments would needed in any case because oldestdeps jobs are not yet reproducible. |
|
Even if you had to tweak some indirect dependency requirement in 8aa1dd2 you'd still be in a much better position than you are right now. |
|
actually I am not able to checkout that exact commit, even after adding your fork as a remote. Adding 28901cd on top of it should be sufficient to emulate the situation back then. Can you please give it a try ? |
|
I already did you a huge favor by pointing you to the exact commit that ran into trouble. |
|
I can't investigate further on my own. If you're not willing to help I can only assume there was no actual incompatibility to begin with. |
|
The full logs have expired, but the fact that the oldest dependencies job failed is still recorded. |
|
Unfortunately this does nothing to lift my suspicion that a mere warning could have been treated as a error, and that would not qualify as an actual incompatibility. |
Description
Warning
disclaimer: this isn't meant to be merged. Ever.
matplotlib< 3.8 #18164numpy< 1.24 #18160context: investigating what the problem was that motivated #18164 by running CI in close conditions.