Skip to content

EXP: revert #18164 - #18971

Closed
neutrinoceros wants to merge 8 commits into
astropy:mainfrom
neutrinoceros:revert-compat
Closed

neutrinoceros wants to merge 8 commits into
astropy:mainfrom
neutrinoceros:revert-compat

Conversation

@neutrinoceros

@neutrinoceros neutrinoceros commented Nov 19, 2025 •

Copy link
Copy Markdown
Contributor

Description

Warning

disclaimer: this isn't meant to be merged. Ever.

context: investigating what the problem was that motivated #18164 by running CI in close conditions.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@eerovaher

Copy link
Copy Markdown
Member

If you wanted to know what went wrong with 8aa1dd2 then you could have just tested that commit directly.

@neutrinoceros

Copy link
Copy Markdown
Contributor Author

Adjustments would needed in any case because oldestdeps jobs are not yet reproducible.

@eerovaher

Copy link
Copy Markdown
Member

Even if you had to tweak some indirect dependency requirement in 8aa1dd2 you'd still be in a much better position than you are right now.

@neutrinoceros

neutrinoceros commented Nov 20, 2025 •

Copy link
Copy Markdown
Contributor Author

actually I am not able to checkout that exact commit, even after adding your fork as a remote. Adding 28901cd on top of it should be sufficient to emulate the situation back then. Can you please give it a try ?

@eerovaher

Copy link
Copy Markdown
Member

I already did you a huge favor by pointing you to the exact commit that ran into trouble.

@neutrinoceros

Copy link
Copy Markdown
Contributor Author

I can't investigate further on my own. If you're not willing to help I can only assume there was no actual incompatibility to begin with.

@eerovaher

Copy link
Copy Markdown
Member

The full logs have expired, but the fact that the oldest dependencies job failed is still recorded.

@neutrinoceros

Copy link
Copy Markdown
Contributor Author

Unfortunately this does nothing to lift my suspicion that a mere warning could have been treated as a error, and that would not qualify as an actual incompatibility.

@neutrinoceros
neutrinoceros deleted the revert-compat branch March 16, 2026 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants