Skip to content

feat(cosmo): add MRT to I/O options - #18952

Merged
nstarman merged 14 commits into
astropy:mainfrom
nstarman:cosmo/io/mrt
Apr 24, 2026
Merged

nstarman merged 14 commits into
astropy:mainfrom
nstarman:cosmo/io/mrt

Conversation

@nstarman

@nstarman nstarman commented Nov 17, 2025 •

Copy link
Copy Markdown
Member

Closes #14871

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@nstarman nstarman moved this from Triage to In Progress in Cosmology, the Expansion Nov 17, 2025
@nstarman
nstarman marked this pull request as ready for review November 17, 2025 06:31
@nstarman
nstarman requested a review from a team as a code owner November 17, 2025 06:31
@nstarman
nstarman marked this pull request as draft November 18, 2025 01:52
@mhvk

mhvk commented Nov 18, 2025

Copy link
Copy Markdown
Contributor

Will try to have a look, but may have to be in a few weeks, as teaching is taking most of my time...

@nstarman

Copy link
Copy Markdown
Member Author

@mhvk thanks! No rush on this one. I don't think people are burning to have MRT support. It will be more useful when I finally figure out how to implement array-valued cosmologies.

@taldcroft

Copy link
Copy Markdown
Member

I can have a look when it comes out of draft. 😄

Signed-off-by: nstarman <[email protected]>
@nstarman
nstarman marked this pull request as ready for review November 19, 2025 16:41
@nstarman

Copy link
Copy Markdown
Member Author

Ping @taldcroft. Thanks! :)

@github-actions github-actions Bot added the Close? Tell stale bot that this issue/PR is stale label Apr 19, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Hi humans 👋 - this pull request hasn't had any new commits for approximately 4 months. I plan to close this in 30 days if the pull request doesn't have any new commits by then.

In lieu of a stalled pull request, please consider closing this and open an issue instead if a reminder is needed to revisit in the future. Maintainers may also choose to add keep-open label to keep this PR open but it is discouraged unless absolutely necessary.

If this PR still needs to be reviewed, as an author, you can rebase it to reset the clock.

If you believe I commented on this pull request incorrectly, please report this here.

@nstarman nstarman added keep-open and removed Close? Tell stale bot that this issue/PR is stale labels Apr 19, 2026
@nstarman

Copy link
Copy Markdown
Member Author

Ping @taldcroft for a review :)

@taldcroft

Copy link
Copy Markdown
Member

@nstarman - sorry, I'll have a look at this.

@taldcroft taldcroft left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @nstarman!

@github-project-automation github-project-automation Bot moved this from In Progress to Reviewer approved in Cosmology, the Expansion Apr 24, 2026
@nstarman
nstarman merged commit 49bbb56 into astropy:main Apr 24, 2026
41 of 42 checks passed
@github-project-automation github-project-automation Bot moved this from Reviewer approved to Done in Cosmology, the Expansion Apr 24, 2026
@nstarman
nstarman deleted the cosmo/io/mrt branch April 24, 2026 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Cosmology read & write method for AAS MRT

4 participants