Skip to content

Backport PR #18849 on branch v7.2.x (BUG: fix forward compatibility for np.arange(<Quantity>, ...) against numpy 2.4 (dev)) - #18888

Merged
neutrinoceros merged 1 commit into
astropy:v7.2.xfrom
meeseeksmachine:auto-backport-of-pr-18849-on-v7.2.x
Nov 14, 2025
Merged

neutrinoceros merged 1 commit into
astropy:v7.2.xfrom
meeseeksmachine:auto-backport-of-pr-18849-on-v7.2.x

Conversation

@meeseeksmachine

Copy link
Copy Markdown

Backport PR #18849: BUG: fix forward compatibility for np.arange(<Quantity>, ...) against numpy 2.4 (dev)

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@pllim

pllim commented Nov 11, 2025

Copy link
Copy Markdown
Member

@neutrinoceros , did we forget to backport something else? I still see 1 failure here:

FAILED astropy/units/tests/test_quantity_non_ufuncs.py::TestFunctionHelpersSignatureCompatibility::test_all_arguments_reexposed[array-array] - AssertionError: argument 'ndmax' is not re-exposed as keyword

@neutrinoceros

Copy link
Copy Markdown
Contributor

We just forgot to merge #18846
I'll do it now and restart this one (possibly with a rebase)

…nge(<Quantity>, ...)` against numpy 2.4 (dev)
@neutrinoceros
neutrinoceros force-pushed the auto-backport-of-pr-18849-on-v7.2.x branch from bffeccc to 9fae326 Compare November 12, 2025 05:30
@neutrinoceros

Copy link
Copy Markdown
Contributor

hum, the remaining failure is surprising, it should already have been fixed with #18886
I'll see if there's anything else we missed

@neutrinoceros

neutrinoceros commented Nov 12, 2025 •

Copy link
Copy Markdown
Contributor

Ah, I see what happened. #18885 (and its backport #18886) only fixed unit, not utils.masked, which is what we're seeing here. I'll handle it with a new PR.

update: for reference #18889

@astrofrog

Copy link
Copy Markdown
Member

@neutrinoceros - just to make sure I understand, is this present backport good to go?

@neutrinoceros

Copy link
Copy Markdown
Contributor

Yes.

@neutrinoceros

Copy link
Copy Markdown
Contributor

for completeness, the complementary fix is now backported at #18892

@neutrinoceros
neutrinoceros merged commit bb652e9 into astropy:v7.2.x Nov 14, 2025
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants