Repository navigation
TST/DEP: drop pytest-cov in favor of using coverage.py directly - #18879
neutrinoceros wants to merge 1 commit into
Conversation
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
|
👋 Thank you for your draft pull request! Do you know that you can use |
bd71928 to
3e3ede8
Compare
|
Now computing coverage is 2 steps, versus 1 with |
|
yes. This seems like a very reasonable price to pay to rid ourselves of a dependency, in my opinion. However, I did discover a blocking issue with this approach, reported upstream at OpenAstronomy/github-actions-workflows#330 |
|
I'm 🤷 on this. I've never had an issue with pytest-cov but I appreciate wanting to streamline dependencies. |
|
FWIW I can't say I never had any issue with using |
|
Hi humans 👋 - this pull request hasn't had any new commits for approximately 4 months. I plan to close this in 30 days if the pull request doesn't have any new commits by then. In lieu of a stalled pull request, please consider closing this and open an issue instead if a reminder is needed to revisit in the future. Maintainers may also choose to add keep-open label to keep this PR open but it is discouraged unless absolutely necessary. If this PR still needs to be reviewed, as an author, you can rebase it to reset the clock. If you believe I commented on this pull request incorrectly, please report this here. |
I'm interested. What problems? |
|
Sorry this got drowned in other notifications... I don't recall any specific incident regarding
|
3e3ede8 to
f2b9064
Compare
|
If getting rid of it has no impact, then 🤷 sure :) |
|
@zacharyburnett or @Cadair , any opinions here? Thanks, all! |
|
Hi humans 👋 - this pull request hasn't had any new commits for approximately 6 months. I plan to close this in a month if the pull request doesn't have any new commits by then. In lieu of a stalled pull request, please consider closing this and open an issue instead if a reminder is needed to revisit in the future. Maintainers may also choose to add keep-open label to keep this PR open but it is discouraged unless absolutely necessary. If this PR still needs to be reviewed, as an author, you can rebase it to reset the clock. If you believe I commented on this pull request incorrectly, please report this here. |
f2b9064 to
ffe9423
Compare
zacharyburnett
left a comment
There was a problem hiding this comment.
Removing dependencies is always good!
ffe9423 to
b05a5b3
Compare
Description
ref: #18878
This PR makes pytest-cov unused. As mentionned on the issue, however, removing pytest-cov from the env graph will also require #18783.