Repository navigation
Neutrino component - #18809
Neutrino component#18809
Conversation
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
|
👋 Thank you for your draft pull request! Do you know that you can use |
42725d5 to
be21e0c
Compare
|
@nstarman If the total component gets merged. I will work on the docs and changes and changes. |
b390b61 to
29fcd96
Compare
nstarman
left a comment
There was a problem hiding this comment.
A few comments. Overall, looking good.
|
@nstarman This is now a different milestone ? I think it might be finally ready for a review and a merge. Have a bit more time in the coming weeks will help you this forward. |
|
@preshanth can you rebase and change the whatsnew to 8.0.rst ? |
b76b8ee to
98ddd20
Compare
|
@nstarman working on it. Some docstests are failing after rebase. Will fix and push. Only check when I mark this as ready for review |
|
@nstarman I could use a suggestion of which way to go. The |
9a130b8 to
10964cf
Compare
|
@nstarman I rebased and did a bit more than what I was planning. Cause it was annoying me. Have a look at |
10964cf to
e8b7af1
Compare
|
Sorry. Recently merged PRs mean you rebase to rebase this one. |
It was a lot cleaner to do that. _nu_info is a cached property that auto computes. Added a full custom cosmology mimicking FLRW
…mmended I have also reduced the doctests to reflect that
Co-authored-by: Nathaniel Starkman <[email protected]>
237de57 to
2a398ed
Compare
|
@nstarman Hopefully one last review. I hope I got all the rebasing right. |
|
Thanks for the assist. |
nstarman
left a comment
There was a problem hiding this comment.
Awesome, thanks @preshanth. This was definitely the most challenging of the component separations!
|
@preshanth we have this group if you're interested: https://github.com/orgs/astropy/teams/astropy-contributors |
|
@nstarman That sounds good. I can't access it however is giving me a 404. |
Description
This pull request introduces the neutrino component trait class into cosmology
Fixes a portion of #17150
CC @nstarman