Skip to content

Neutrino component - #18809

Merged
nstarman merged 14 commits into
astropy:mainfrom
preshanth:neutrinocomponent
Nov 18, 2025
Merged

nstarman merged 14 commits into
astropy:mainfrom
preshanth:neutrinocomponent

Conversation

@preshanth

@preshanth preshanth commented Oct 30, 2025 •

Copy link
Copy Markdown
Contributor

Description

This pull request introduces the neutrino component trait class into cosmology

Fixes a portion of #17150

CC @nstarman

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@preshanth preshanth changed the title Initial commit of the neutrino component trait Neeutrino component Oct 30, 2025
@preshanth preshanth changed the title Neeutrino component Neutrino component Oct 30, 2025
Comment thread astropy/cosmology/_src/flrw/base.py Resolved
Comment thread astropy/cosmology/_src/flrw/base.py Resolved
@preshanth

Copy link
Copy Markdown
Contributor Author

@nstarman If the total component gets merged. I will work on the docs and changes and changes.

@nstarman nstarman moved this from Triage to In Progress in Cosmology, the Expansion Oct 31, 2025
@nstarman nstarman added this to the v7.2.0 milestone Nov 1, 2025
Comment thread astropy/cosmology/_src/flrw/base.py Resolved

@nstarman nstarman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments. Overall, looking good.

Comment thread astropy/cosmology/_src/flrw/base.py Resolved
@astrofrog astrofrog modified the milestones: v7.2.0, v8.0.0 Nov 3, 2025
@preshanth

Copy link
Copy Markdown
Contributor Author

@nstarman This is now a different milestone ? I think it might be finally ready for a review and a merge. Have a bit more time in the coming weeks will help you this forward.

@nstarman nstarman mentioned this pull request Nov 11, 2025
12 of 22 tasks
@nstarman

Copy link
Copy Markdown
Member

@preshanth can you rebase and change the whatsnew to 8.0.rst ?

@preshanth

Copy link
Copy Markdown
Contributor Author

@nstarman working on it. Some docstests are failing after rebase. Will fix and push. Only check when I mark this as ready for review

@preshanth

preshanth commented Nov 11, 2025 •

Copy link
Copy Markdown
Contributor Author

@nstarman I could use a suggestion of which way to go. The _nu_info method I think should be an abstract method in the trait. Then I want to move the _nu_info into a method inside flrw and then I can show a real custom neutrino cosmology. Currently that is not that case. Do you think that makes sense to you. If you say yes I will go ahead and implement that.
I have rebased and fixed the whatsnew issue. Just was realizing that the docs examples don't really show an actual neutrino component trait.

@preshanth
preshanth force-pushed the neutrinocomponent branch 2 times, most recently from 9a130b8 to 10964cf Compare November 12, 2025 00:46
@preshanth

Copy link
Copy Markdown
Contributor Author

@nstarman I rebased and did a bit more than what I was planning. Cause it was annoying me. Have a look at neutrino.py I introduced another private class there made the neutrinos more trait like and independent. I also showed an FLRW like class in the docs as an example.

@preshanth
preshanth marked this pull request as ready for review November 12, 2025 01:36
@preshanth
preshanth requested a review from a team as a code owner November 12, 2025 01:36
@preshanth
preshanth requested a review from nstarman November 12, 2025 01:36
@preshanth
preshanth requested a review from nstarman November 14, 2025 23:34
@nstarman

Copy link
Copy Markdown
Member

Sorry. Recently merged PRs mean you rebase to rebase this one.

Comment thread astropy/cosmology/_src/flrw/base.py Resolved
@preshanth

Copy link
Copy Markdown
Contributor Author

@nstarman Hopefully one last review. I hope I got all the rebasing right.

Comment thread astropy/cosmology/_src/flrw/base.py Resolved
@github-project-automation github-project-automation Bot moved this from Review in progress to Reviewer approved in Cosmology, the Expansion Nov 18, 2025
@preshanth

Copy link
Copy Markdown
Contributor Author

Thanks for the assist.

@nstarman nstarman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @preshanth. This was definitely the most challenging of the component separations!

@nstarman
nstarman enabled auto-merge (squash) November 18, 2025 01:47
@nstarman

Copy link
Copy Markdown
Member

@preshanth

Copy link
Copy Markdown
Contributor Author

@nstarman That sounds good. I can't access it however is giving me a 404.

@nstarman
nstarman merged commit d64ad35 into astropy:main Nov 18, 2025
33 checks passed
@github-project-automation github-project-automation Bot moved this from Reviewer approved to Done in Cosmology, the Expansion Nov 18, 2025
@preshanth
preshanth deleted the neutrinocomponent branch November 18, 2025 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants