Skip to content

feat(cosmo): DistanceMeasures trait class - #18808

Open
nstarman wants to merge 2 commits into
astropy:mainfrom
nstarman:cosmo/traits/distance-measures
Open

feat(cosmo): DistanceMeasures trait class#18808
nstarman wants to merge 2 commits into
astropy:mainfrom
nstarman:cosmo/traits/distance-measures

Conversation

@nstarman

@nstarman nstarman commented Oct 30, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

This PR requires a fair bit of setup:

CC @preshanth

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@nstarman nstarman added this to the v8.0.0 milestone Oct 30, 2025
@nstarman nstarman changed the title feat(cosmo): distance measures traits feat(cosmo): distance measures trait class Oct 30, 2025
@github-actions

github-actions Bot commented Oct 30, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

github-actions Bot commented Oct 30, 2025

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@nstarman
nstarman force-pushed the cosmo/traits/distance-measures branch from 7f0bd9e to 8d9012e Compare October 30, 2025 17:54
@nstarman nstarman moved this from Triage to In Progress in Cosmology, the Expansion Oct 30, 2025
@nstarman
nstarman force-pushed the cosmo/traits/distance-measures branch 2 times, most recently from 344a4f6 to 657e005 Compare October 30, 2025 18:03
@nstarman nstarman changed the title feat(cosmo): distance measures trait class feat(cosmo): DistanceMeasures trait class Oct 30, 2025
@nstarman
nstarman force-pushed the cosmo/traits/distance-measures branch from 657e005 to 3ead80b Compare November 10, 2025 17:46
This was referenced Nov 11, 2025
Draft
Open
@nstarman
nstarman force-pushed the cosmo/traits/distance-measures branch from 3ead80b to 2334a07 Compare November 18, 2025 03:00
@github-actions github-actions Bot added the Close? Tell stale bot that this issue/PR is stale label Apr 18, 2026
@github-actions

github-actions Bot commented Apr 18, 2026

Copy link
Copy Markdown
Contributor

Hi humans 👋 - this pull request hasn't had any new commits for approximately 4 months. I plan to close this in 30 days if the pull request doesn't have any new commits by then.

In lieu of a stalled pull request, please consider closing this and open an issue instead if a reminder is needed to revisit in the future. Maintainers may also choose to add keep-open label to keep this PR open but it is discouraged unless absolutely necessary.

If this PR still needs to be reviewed, as an author, you can rebase it to reset the clock.

If you believe I commented on this pull request incorrectly, please report this here.

@astrofrog astrofrog modified the milestones: v8.0.0, v8.1.0 May 5, 2026
@nstarman nstarman added keep-open and removed Close? Tell stale bot that this issue/PR is stale labels May 14, 2026
@nstarman
nstarman force-pushed the cosmo/traits/distance-measures branch 3 times, most recently from 95a6b41 to 9af1753 Compare July 14, 2026 22:11
@nstarman
nstarman marked this pull request as ready for review July 14, 2026 22:12
@nstarman
nstarman requested a review from a team as a code owner July 14, 2026 22:12
@nstarman

nstarman commented Jul 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

@neutrinoceros we're finally here! A long PR sequence. Next up: #18876 🚀

@nstarman
nstarman force-pushed the cosmo/traits/distance-measures branch from 818daa4 to ecd3cef Compare July 29, 2026 12:39
@nstarman

nstarman commented Jul 29, 2026

Copy link
Copy Markdown
Member Author

@neutrinoceros, rebasing to hopefully pick up a fix for the failing allowed_failures job.

nstarman and others added 2 commits September 13, 2026 14:45
@nstarman
feat(cosmo): distance measures
693110b 
Signed-off-by: nstarman <[email protected]>
@nstarman @claude
DOC: fix unresolved z_at_value cross-references in DistanceMeasures
64e7bbf 
The `See Also` entries in DistanceMeasures docstrings referenced the bare
name `z_at_value`, which numpydoc resolves relative to the documenting
module (`astropy.cosmology._src.traits.distances`) where the name is not
in scope. This produced four `py:obj reference target not found` warnings,
failing the RTD build under `fail_on_warning`. Fully-qualify the reference
as `astropy.cosmology.z_at_value` using numpydoc's two-line form.

Co-Authored-By: Claude Opus 4.8 <[email protected]>
@nstarman
nstarman force-pushed the cosmo/traits/distance-measures branch from ecd3cef to 64e7bbf Compare September 13, 2026 18:45
@nstarman

nstarman commented Sep 13, 2026

Copy link
Copy Markdown
Member Author

@neutrinoceros, rebasing to hopefully pick up a fix for the failing allowed_failures job.

@pllim pllim removed the keep-open label Oct 14, 2026
@nstarman

nstarman commented Nov 8, 2026

Copy link
Copy Markdown
Member Author

Ping @neutrinoceros for a review. :) Relevant CI is passing.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@preshanth preshanth Awaiting requested review from preshanth
@neutrinoceros neutrinoceros Awaiting requested review from neutrinoceros

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

cosmology

Projects

Cosmology, the Expansion
Status: In Progress

Milestone

v8.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@nstarman @astrofrog @pllim