Repository navigation
feat(cosmo): complete the keyword argument deprecations - #18800
Conversation
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
|
👋 Thank you for your draft pull request! Do you know that you can use |
|
Does require a changelog. I'll wait until v7.2 is released. |
There was a problem hiding this comment.
This came out in a discussion about CPython's documentation; some users lamented the fact that deprecated and removed stuff would simply vanish from documentation, making it more difficult to navigate and find where and when changes occurred.
I would suggest keeping .. versionchanged:: 7.0 sections around in docstring and adding a .. versionchanged:: 8.0 instead of removing everything.
d474da0 to
9dd5e89
Compare
|
SGTM. I've kept them for all public methods. For private methods passing positional arguments is backwards compatible. |
|
@pllim, Now that v7.2 branch has been made, is it safe to start merging in v8.0 content? |
9dd5e89 to
6496fa6
Compare
Yes, but you should rebase, just to be sure the branch is still OK. Thanks. |
b554acb to
7e33b0d
Compare
|
@pllim, our pre-commit appears to be broken :(. |
|
GitHub is unstable right now; we just have to wait it out and then you have to retrigger. FYI. |
Signed-off-by: nstarman <[email protected]>
7e33b0d to
adf73fb
Compare
|
@pllim it stabilized long enough for this to pass :). |
|
I'll give @neutrinoceros a chance to review also since he had comments above. Thanks! |
|
@neutrinoceros this PR hasn't changed much since your last review. I added the |
|
@neutrinoceros, maybe a good follow up to this PR would be moving the decorator into |
|
Sorry for dropping the ball. LGTM now. Yes, we can move this code next time we need it. If it doesn't find a new use case in astropy 8.0, we should probably just remove it entirely |
|
I opened #18951 to follow up. |
Finally.
Closes #16614