Skip to content

feat(cosmo): complete the keyword argument deprecations - #18800

Merged
neutrinoceros merged 1 commit into
astropy:mainfrom
nstarman:cosmo/api/pos-args
Nov 16, 2025
Merged

neutrinoceros merged 1 commit into
astropy:mainfrom
nstarman:cosmo/api/pos-args

Conversation

@nstarman

@nstarman nstarman commented Oct 30, 2025 •

Copy link
Copy Markdown
Member

Finally.
Closes #16614

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@nstarman

Copy link
Copy Markdown
Member Author

Does require a changelog. I'll wait until v7.2 is released.

@neutrinoceros neutrinoceros left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This came out in a discussion about CPython's documentation; some users lamented the fact that deprecated and removed stuff would simply vanish from documentation, making it more difficult to navigate and find where and when changes occurred.
I would suggest keeping .. versionchanged:: 7.0 sections around in docstring and adding a .. versionchanged:: 8.0 instead of removing everything.

@nstarman

nstarman commented Oct 30, 2025 •

Copy link
Copy Markdown
Member Author

SGTM. I've kept them for all public methods. For private methods passing positional arguments is backwards compatible.

@nstarman

nstarman commented Nov 8, 2025

Copy link
Copy Markdown
Member Author

@pllim, Now that v7.2 branch has been made, is it safe to start merging in v8.0 content?

@nstarman
nstarman marked this pull request as ready for review November 8, 2025 22:01
@nstarman
nstarman requested a review from a team as a code owner November 8, 2025 22:01
@pllim

pllim commented Nov 10, 2025

Copy link
Copy Markdown
Member

is it safe to start merging in v8.0 content?

Yes, but you should rebase, just to be sure the branch is still OK. Thanks.

@nstarman
nstarman force-pushed the cosmo/api/pos-args branch 2 times, most recently from b554acb to 7e33b0d Compare November 10, 2025 17:26
@nstarman

Copy link
Copy Markdown
Member Author

@pllim, our pre-commit appears to be broken :(.

@pllim

pllim commented Nov 10, 2025

Copy link
Copy Markdown
Member

GitHub is unstable right now; we just have to wait it out and then you have to retrigger. FYI.

@nstarman

Copy link
Copy Markdown
Member Author

@pllim it stabilized long enough for this to pass :).

@pllim

pllim commented Nov 10, 2025

Copy link
Copy Markdown
Member

I'll give @neutrinoceros a chance to review also since he had comments above. Thanks!

@nstarman

Copy link
Copy Markdown
Member Author

@neutrinoceros this PR hasn't changed much since your last review. I added the .. versionchanged and a changelog. :).

@nstarman

nstarman commented Nov 14, 2025 •

Copy link
Copy Markdown
Member Author

@neutrinoceros, maybe a good follow up to this PR would be moving the decorator into astropy.utils ? I don't think it's used in cosmology anymore.

@neutrinoceros

Copy link
Copy Markdown
Contributor

Sorry for dropping the ball. LGTM now. Yes, we can move this code next time we need it. If it doesn't find a new use case in astropy 8.0, we should probably just remove it entirely

@github-project-automation github-project-automation Bot moved this from In Progress to Reviewer approved in Cosmology, the Expansion Nov 16, 2025
@neutrinoceros
neutrinoceros merged commit 5f1b370 into astropy:main Nov 16, 2025
32 of 33 checks passed
@github-project-automation github-project-automation Bot moved this from Reviewer approved to Done in Cosmology, the Expansion Nov 16, 2025
@neutrinoceros
neutrinoceros deleted the cosmo/api/pos-args branch November 16, 2025 15:59
@neutrinoceros

Copy link
Copy Markdown
Contributor

I opened #18951 to follow up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Reminder: remove astropy.cosmology._utils.deprecated_keywords for astropy 8.0.0

3 participants