Skip to content

Add arm64 windows support - #18786

Merged
pllim merged 17 commits into
astropy:mainfrom
finnagin:arm64-runner
Oct 28, 2025
Merged

Add arm64 windows support#18786
pllim merged 17 commits into
astropy:mainfrom
finnagin:arm64-runner

Conversation

@finnagin

@finnagin finnagin commented Oct 27, 2025

Copy link
Copy Markdown
Contributor

Description

This pull request is to add windows arm64 wheel builds and tests.

Fixes #18785

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions

github-actions Bot commented Oct 27, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

neutrinoceros
neutrinoceros previously requested changes Oct 27, 2025
View reviewed changes

@neutrinoceros neutrinoceros left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! this is definitely appreciated. A couple things to edit before we merge though.

Comment thread .github/workflows/ci_workflows.yml Resolved
Comment thread .github/workflows/publish.yml Resolved
Comment thread docs/changes/18786.other.rst Resolved
@neutrinoceros neutrinoceros added the Build all wheels Run all the wheel builds rather than just a selection label Oct 27, 2025
@neutrinoceros neutrinoceros added this to the v7.1.2 milestone Oct 27, 2025
pllim
pllim approved these changes Oct 28, 2025
View reviewed changes

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, all!

@neutrinoceros
neutrinoceros enabled auto-merge (squash) October 28, 2025 14:34
@pllim
pllim disabled auto-merge October 28, 2025 14:43
@pllim

pllim commented Oct 28, 2025

Copy link
Copy Markdown
Member

FYI -- I disabled auto merge. I want to make sure wheels are all okay but they are not required jobs. I will manually squash merge when everything is green. Thanks for your understanding!

@neutrinoceros

neutrinoceros commented Oct 28, 2025

Copy link
Copy Markdown
Contributor

No worries, thanks for clarifying !

@pllim
pllim merged commit 253ce34 into astropy:main Oct 28, 2025
4 checks passed
@lumberbot-app

This comment was marked as resolved.

Sign in to view
@pllim

This comment was marked as resolved.

Sign in to view
@neutrinoceros

neutrinoceros commented Oct 28, 2025

Copy link
Copy Markdown
Contributor

I don't know. @finnagin how much of a hurry is there ?
I don't think it would be too bad to backport manually, but I'll wait for more inputs.

pllim added a commit to pllim/astropy that referenced this pull request Oct 28, 2025
@pllim
Backport of astropy#18786 onto v7.1.x
79758e5 
to add build for Windows ARM64.

Also backport the ignore added in astropy#18573
so devs do not accidentally check in pyi files when switching
branches locally.
@pllim

pllim commented Oct 28, 2025

Copy link
Copy Markdown
Member

It's ok I will manually backport.

@pllim pllim mentioned this pull request Oct 28, 2025
Merged
1 task
pllim added a commit that referenced this pull request Oct 28, 2025
@pllim
Backport of #18786 onto v7.1.x (#18793)
7118415 
to add build for Windows ARM64.

Also backport the ignore added in #18573
so devs do not accidentally check in pyi files when switching
branches locally.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Cadair Cadair Cadair left review comments
@pllim pllim pllim approved these changes
@neutrinoceros neutrinoceros neutrinoceros approved these changes

Assignees

No one assigned

Labels

Build all wheels Run all the wheel builds rather than just a selection Release testing

Projects

None yet

Milestone

v7.1.2

Development

Successfully merging this pull request may close these issues.

Add arm64 windows support

4 participants

@finnagin @pllim @neutrinoceros @Cadair