Repository navigation
Updating to add a trait class for darkmatter in cosmology. - #18760
Conversation
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
|
👋 Thank you for your draft pull request! Do you know that you can use |
|
@nstarman If I am right this was a really small PR. I marked it as an internal class rather than a public one. Where do you want to impose checks such as say matter density = darkmatter + baryons and such ? I know its cosmology specific I was referring it to it in the context of FLRW. |
nstarman
left a comment
There was a problem hiding this comment.
Let's actually make this public API! So this means a changelog is necessary.
Where do you want to impose checks such as say matter density = darkmatter + baryons and such
The check shouldn't be in these trait classes, so let's leave it up to the downstream classes that use the traits. It's worth further thought if there's a good way to help systematize these checks.
nstarman
left a comment
There was a problem hiding this comment.
Thanks @preshanth!
One very small nitpick.
|
So for turning these three ``` _BaryonComponent, _CriticalDensity, _MatterComponent," into public want one PR per component or a single PR ? |
|
A single PR is good. |
|
Thanks @preshanth ! |
Description
This pull request adds the darkmatter component trait class to cosmology.
Fixes a part of #17150