Repository navigation
Recommend alternatives when a unit isn't found - #1870
Merged
Merged
Conversation
Contributor
Author
|
This at least somewhat addresses #1520. |
Contributor
Author
|
@embray: Any opinions about milestoning this? It definitely doesn't change the API, but it's not really a bugfix either... |
Member
|
👍 |
Member
|
I don't have a strong preference of 0.3.1 vs 0.4.0. @embray? |
Contributor
Author
|
Closes #1520. |
e.g. ångström -> angstrom. Fix some other Unicode-related issues.
mdboom
added a commit
that referenced
this pull request
Dec 30, 2013
Recommend alternatives when a unit isn't found
mdboom
added a commit
that referenced
this pull request
Feb 12, 2014
Recommend alternatives when a unit isn't found
mdboom
added a commit
that referenced
this pull request
Feb 12, 2014
Recommend alternatives when a unit isn't found
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This presents helpful exceptions with "closely matched" units (using difflib).
It also simplifies some unit parsing error messages so they don't contain so much redundant information.
Before:
After: