Repository navigation
Fix simple-to-address typing errors in coordinates - #18695
Merged
Merged
Conversation
The changes here halve the number of errors Mypy reports if invoked with `mypy --follow-imports silent --exclude tests/ -- astropy/coordinates/` In most cases the cause of the reported error was a missing annotation, which caused Mypy to automatically infer a type that was too narrow. Sometimes the correct place for the annotation was a parent class outside `coordinates`.
eerovaher
added
units
coordinates
utils
no-changelog-entry-needed
typing
Contributor
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
mhvk
approved these changes
Oct 10, 2025
mhvk
left a comment
mhvk
left a comment
Contributor
There was a problem hiding this comment.
I'm arguably not the right person to review typing PRs, but this looks good as far as I can tell.
1 task done
Member
|
Merging since approved by the relevant maintainer |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The changes here halve the number of errors Mypy reports if invoked with
In most cases the cause of the reported error was a missing annotation, which caused Mypy to automatically infer a type that was too narrow. Sometimes the correct place for the annotation was a parent class outside
coordinates.