Repository navigation
Ensure no global changes to the warnings filter. - #18568
Merged
Merged
Conversation
mhvk
added
testing
units
Bug
Affects-dev
Contributor
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
mhvk
commented
Aug 29, 2025
| stub_lines = generate_stub_lines(module) | ||
| _write_stub_file(stub_file_path, stub_lines) | ||
| # Ignore deprecation warnings triggered by accessing units in deprecated.py | ||
| with warnings.catch_warnings(action="ignore", category=AstropyDeprecationWarning): |
Contributor
Author
There was a problem hiding this comment.
Available since python 3.11, which is our minimum version.
nstarman
approved these changes
Aug 29, 2025
Member
|
The devdeps pickling failures are unrelated (#18569) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18567.
Ping @nstarman, @mikez - I think this ensures that we don't show DeprecationWarnings yet do not affect code running later. I found that the test now no longer has to worry about them, so it seems better.