Skip to content

Backport PR #18329 on branch v7.1.x (Avoid stringified type annotations in units) - #18555

Merged
mhvk merged 1 commit into
astropy:v7.1.xfrom
eerovaher:backport-18329
Aug 26, 2025
Merged

mhvk merged 1 commit into
astropy:v7.1.xfrom
eerovaher:backport-18329

Conversation

@eerovaher

Copy link
Copy Markdown
Member

Description

This is a manual backport of #18329. It is required to prevent or solve problems analogous to those reported in #18221. The diff looks very large because the implementations of UnitBase and PhysicalType had to be moved to avoid forward references.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

The backport is required to prevent/solve problems analogous to those
reported in astropy#18221.
@eerovaher eerovaher added this to the v7.1.1 milestone Aug 26, 2025
@eerovaher
eerovaher requested a review from mhvk August 26, 2025 19:01
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@eerovaher eerovaher added skip-basebranch-check Skip base branch check for direct backports Manual Backport labels Aug 26, 2025
@mhvk mhvk added skip-basebranch-check Skip base branch check for direct backports and removed skip-basebranch-check Skip base branch check for direct backports labels Aug 26, 2025
@mhvk

mhvk commented Aug 26, 2025

Copy link
Copy Markdown
Contributor

closing/opening to see if that lets the mandatory checks pass (really, skip-basebranch-check should do it...)

@mhvk mhvk closed this Aug 26, 2025
@mhvk mhvk reopened this Aug 26, 2025

@mhvk mhvk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for backport

@mhvk
mhvk enabled auto-merge August 26, 2025 19:14
@mhvk
mhvk merged commit 188800d into astropy:v7.1.x Aug 26, 2025
@eerovaher
eerovaher deleted the backport-18329 branch August 26, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Manual Backport no-changelog-entry-needed skip-basebranch-check Skip base branch check for direct backports typing related to type annotations units

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants