Skip to content

Backport PR #18139 on v7.1.x (TST: improve ArrayWrapper roundtrips (preserve dtype byteorder)) - #18461

Merged
pllim merged 1 commit into
astropy:v7.1.xfrom
neutrinoceros:bp/18139
Jul 25, 2025
Merged

pllim merged 1 commit into
astropy:v7.1.xfrom
neutrinoceros:bp/18139

Conversation

@neutrinoceros

@neutrinoceros neutrinoceros commented Jul 25, 2025 •

Copy link
Copy Markdown
Contributor

Description

Manual backport for #18139 after seeing that it wasn't (fully) included in 7.1.0 as previously assumed.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

…undtrips (preserve dtype byteorder))
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@neutrinoceros neutrinoceros added the skip-changelog-checks Tells bot to skip changlog checks label Jul 25, 2025
@neutrinoceros
neutrinoceros marked this pull request as ready for review July 25, 2025 08:21
@neutrinoceros
neutrinoceros requested a review from taldcroft as a code owner July 25, 2025 08:21
@pllim

pllim commented Jul 25, 2025

Copy link
Copy Markdown
Member

I don't understand why the auto backport only picked up 2 lines in #18156 nor why @nstarman approved it. What was going on? 🤯

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does look like the rest of the code in the original PR that the bot somehow missed. Thanks!

@github-project-automation github-project-automation Bot moved this from Triage to Reviewer approved in Cosmology, the Expansion Jul 25, 2025
@pllim
pllim merged commit d0cedbc into astropy:v7.1.x Jul 25, 2025
@github-project-automation github-project-automation Bot moved this from Reviewer approved to Done in Cosmology, the Expansion Jul 25, 2025
@neutrinoceros
neutrinoceros deleted the bp/18139 branch July 25, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug cosmology Docs Extra CI Run cron CI as part of PR Manual Backport Python 3.14 skip-basebranch-check Skip base branch check for direct backports skip-changelog-checks Tells bot to skip changlog checks table testing

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants