Skip to content

WHL: test wheels against CPython 3.14 (GIL-enabled) - #18457

Merged
astrofrog merged 1 commit into
astropy:mainfrom
neutrinoceros:whl/test-wheels-on-cp314
Jul 28, 2025
Merged

WHL: test wheels against CPython 3.14 (GIL-enabled)#18457
astrofrog merged 1 commit into
astropy:mainfrom
neutrinoceros:whl/test-wheels-on-cp314

Conversation

@neutrinoceros

@neutrinoceros neutrinoceros commented Jul 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Contributes to #18187
To reduce friction, The patch is future-proof against upgrades in cibuildwheel and OpenAstronomy/github-actions-workflows. A couple lines added here can be cleaned-up in the near future, but we'll be able to do this at our own pace.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@neutrinoceros neutrinoceros added this to the v7.2.0 milestone Jul 24, 2025
@neutrinoceros neutrinoceros added Build all wheels Run all the wheel builds rather than just a selection Python 3.14 no-changelog-entry-needed labels Jul 24, 2025
@github-actions

github-actions Bot commented Jul 24, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

github-actions Bot commented Jul 24, 2025

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@neutrinoceros neutrinoceros changed the title WHL: test wheels against CPython 3.14 (GIL-ennabled) WHL: test wheels against CPython 3.14 (GIL-enabled) Jul 24, 2025
@neutrinoceros
neutrinoceros force-pushed the whl/test-wheels-on-cp314 branch from 78901aa to 212d0f8 Compare July 24, 2025 18:16
@pllim

pllim commented Jul 24, 2025

Copy link
Copy Markdown
Member

win32 not happy with py314

meson.build:40:14: ERROR: Python dependency not found

@neutrinoceros
neutrinoceros force-pushed the whl/test-wheels-on-cp314 branch from 212d0f8 to 59c8933 Compare July 24, 2025 19:43
@neutrinoceros

neutrinoceros commented Jul 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

yup, my bad I think: it failed building matplotlib (which doesn't have nightlies for this platform + Python combo), but we don't actually need it, so let's just install numpy, as is usual in build testing.

@neutrinoceros

neutrinoceros commented Jul 24, 2025

Copy link
Copy Markdown
Contributor Author

🎉 all good now.
This patch would actually work as is on the backport branch, I think, but I predict it won't auto-backport cleanly, so I'll open a twin PR for the backport branch instead.

@neutrinoceros
neutrinoceros marked this pull request as ready for review July 24, 2025 20:13
@neutrinoceros neutrinoceros mentioned this pull request Jul 24, 2025
Merged
1 task
neutrinoceros added a commit to neutrinoceros/astropy that referenced this pull request Jul 24, 2025
@neutrinoceros
WHL: test wheels against CPython 3.14 (GIL-enabled) (twin astropy#18457)
6bb9b14
neutrinoceros
neutrinoceros commented Jul 24, 2025
View reviewed changes
Comment thread pyproject.toml Outdated
Comment on lines +279 to +282
[[tool.cibuildwheel.overrides]]
# Install nightly wheels for dependencies not yet available on PyPI.
select = "cp314*"
before-test = "python -m pip install --pre --extra-index-url https://pypi.anaconda.org/scientific-python-nightly-wheels/simple numpy --only-binary numpy"

@neutrinoceros neutrinoceros Jul 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this part might become obsolete sooner than I expected: numpy/numpy#29438
happy to revisit tomorrow and see where things are then

@neutrinoceros neutrinoceros Jul 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, it is actually being published right now: https://pypi.org/project/numpy/2.3.2/#files
I'll update the PR immediately then

neutrinoceros added a commit to neutrinoceros/astropy that referenced this pull request Jul 24, 2025
@neutrinoceros
WHL: test wheels against CPython 3.14 (GIL-enabled) (twin astropy#18457)
e8d0b18
@neutrinoceros
neutrinoceros force-pushed the whl/test-wheels-on-cp314 branch from 59c8933 to ec2910d Compare July 24, 2025 20:28
neutrinoceros added a commit to neutrinoceros/astropy that referenced this pull request Jul 24, 2025
@neutrinoceros
WHL: test wheels against CPython 3.14 (GIL-enabled) (twin astropy#18457)
9487074
@pllim
pllim requested a review from astrofrog July 24, 2025 21:35
neutrinoceros added a commit to neutrinoceros/astropy that referenced this pull request Jul 25, 2025
@neutrinoceros
WHL: test wheels against CPython 3.14 (GIL-enabled) (twin astropy#18457)
51e491c
astrofrog
astrofrog approved these changes Jul 28, 2025
View reviewed changes

@astrofrog astrofrog left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@astrofrog
astrofrog merged commit ce891f1 into astropy:main Jul 28, 2025
@neutrinoceros
neutrinoceros deleted the whl/test-wheels-on-cp314 branch July 28, 2025 09:39
astrofrog added a commit that referenced this pull request Jul 28, 2025
@astrofrog
Merge pull request #18458 from neutrinoceros/bp/18457
f7773fd 
WHL: build and test wheels against CPython 3.14 (GIL-enabled) (twin #18457)
@neutrinoceros neutrinoceros mentioned this pull request Jul 29, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@astrofrog astrofrog astrofrog approved these changes

Assignees

No one assigned

Labels

Build all wheels Run all the wheel builds rather than just a selection installation no-changelog-entry-needed Python 3.14

Projects

None yet

Milestone

v7.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@neutrinoceros @pllim @astrofrog