Skip to content

Fix pickling tests with spurious xfails in convolution - #18453

Merged
larrybradley merged 1 commit into
astropy:mainfrom
eerovaher:fix-pickling-test
Aug 1, 2025
Merged

larrybradley merged 1 commit into
astropy:mainfrom
eerovaher:fix-pickling-test

Conversation

@eerovaher

Copy link
Copy Markdown
Member

Description

The pickling tests in convolution are overly complicated and they also cause 8 xfails even though pickling works just fine.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@pllim
pllim requested a review from keflavich July 23, 2025 00:46
@pllim

pllim commented Jul 23, 2025

Copy link
Copy Markdown
Member

Why "spurious" in the title? Can you please provide more context? Thanks!

@keflavich

Copy link
Copy Markdown
Contributor

This goes back to #1947 by blame, from which I quote: "Some of the failures are currently xfails by design (e.g. coordinates.DynamicTransform, which can have a function as an attribute)."

I don't know enough to say whether these fails should have stopped happening in the intervening decade.

@eerovaher

Copy link
Copy Markdown
Member Author

If pickling Gaussian1DKernel and Gaussian2DKernel instances succeeds then why should the tests xfail?

@larrybradley larrybradley left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the xfails have resolved themselves, I don't see a reason to keep them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants