Repository navigation
Fix pickling tests with spurious xfails in convolution - #18453
Conversation
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
|
Why "spurious" in the title? Can you please provide more context? Thanks! |
|
This goes back to #1947 by blame, from which I quote: "Some of the failures are currently xfails by design (e.g. coordinates.DynamicTransform, which can have a function as an attribute)." I don't know enough to say whether these fails should have stopped happening in the intervening decade. |
|
If pickling |
d143649 to
55881b7
Compare
larrybradley
left a comment
There was a problem hiding this comment.
Since the xfails have resolved themselves, I don't see a reason to keep them.
…lution` (#18486) Co-authored-by: Larry Bradley <[email protected]>
Description
The pickling tests in
convolutionare overly complicated and they also cause 8 xfails even though pickling works just fine.