Repository navigation
Dark Energy Component Trait Class - #18447
Conversation
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
|
Let me know when you are ready and I will push changes to the changelog and such. I was puzzled by the failures last time around as all tests pass locally. |
Co-authored-by: Nathaniel Starkman <[email protected]>
|
On a bus, sry. limited connection. |
|
I think the DEComponent needs to be added to https://github.com/astropy/astropy/blob/main/astropy/cosmology/traits.py |
|
I am on it. No rush please take your time. Will take me a bit to parse and get to the bottom of it. |
|
So while I fix the docs I want to know if you want this to be publicly exposed or make it an internal reference only class. I just need to put that into base.py so docs can find it or skip accordingly. |
|
Since this has an internal check for inv_efunc I think it can be public! Long term we'll want to move that check from inside the method to a subclassing or initialization check, but for now it's fine. |
|
@nstarman Any suggestions on how to improve the code coverage for traits testing ? |
nstarman
left a comment
There was a problem hiding this comment.
Looking great. I think one more thing.
|
@nstarman The test failure is not related to the code here. Thanks for looking it over. If you are up for it. I have the angular distances as the next one. |
nstarman
left a comment
There was a problem hiding this comment.
Excellent. Thanks @preshanth for another great PR!
Description
This pull request is to introduce a trait class for dark energy as planned in the issue #17150 . The goal here is allow for users to create custom cosmologies using these traits.
Fixes a portion of #17150