Skip to content

feat: Polars Support - #18412

Closed
TheSkyentist wants to merge 11 commits into
astropy:mainfrom
TheSkyentist:polars
Closed

feat: Polars Support#18412
TheSkyentist wants to merge 11 commits into
astropy:mainfrom
TheSkyentist:polars

Conversation

@TheSkyentist

@TheSkyentist TheSkyentist commented Jul 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description:

Adds polars support to Astropy.Table

Motivation:

The discussion in #17146 makes compelling arguments for why the Astropy Table/QTable module exists! However, it is still nice to have features that allow seamless interfacing with other libraries, such as Pandas and Polars. I've added complementary methods to the existing to_pandas and from_pandas, namely to_polars and from_polars along with the a test suite that covers these new functionalities. I'm currently working on the documentation, but wanted to gauge the reception for these utilities.

There was also discussion surrounding narwhals in #17146. I'm currently working on exploring if we can directly add Astropy Table as a supported DF-like library in narwhals.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@TheSkyentist TheSkyentist changed the title Polars support feat: Polars Support Jul 9, 2025
@github-actions

github-actions Bot commented Jul 9, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

github-actions[bot]
github-actions Bot reviewed Jul 9, 2025
View reviewed changes

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Astropy 👋 and congratulations on your first pull request! 🎉

A project member will respond to you as soon as possible; in the meantime, please have a look over the Checklist for Contributed Code and make sure you've addressed as many of the questions there as possible.

If you feel that this pull request has not been responded to in a timely manner, please send a message directly to the development mailing list. If the issue is urgent or sensitive in nature (e.g., a security vulnerability) please send an e-mail directly to the private e-mail [email protected].

@github-actions

github-actions Bot commented Jul 9, 2025

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@pllim pllim added this to the v7.2.0 milestone Jul 9, 2025
@pllim

pllim commented Jul 9, 2025

Copy link
Copy Markdown
Member

Thanks!

Please see the following to assist with current failures:

p.s. So many animals are involved. We can open a zoo soon. 🐼 🐻‍❄️ 🐬

@TheSkyentist

TheSkyentist commented Jul 10, 2025

Copy link
Copy Markdown
Contributor Author

Documentation added, passing all checks, and ready for review! :-)

@TheSkyentist
TheSkyentist marked this pull request as ready for review July 10, 2025 06:51
@TheSkyentist
TheSkyentist requested a review from taldcroft as a code owner July 10, 2025 06:51
@TheSkyentist
TheSkyentist marked this pull request as draft July 10, 2025 09:21
@TheSkyentist

TheSkyentist commented Jul 10, 2025

Copy link
Copy Markdown
Contributor Author

Converting back to draft, considering scrapping this and just replacing with a universal narwhals layer.

@TheSkyentist TheSkyentist mentioned this pull request Jul 15, 2025
Merged
1 task
@TheSkyentist

TheSkyentist commented Jul 15, 2025

Copy link
Copy Markdown
Contributor Author

Superseded by #18435.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments
@taldcroft taldcroft Awaiting requested review from taldcroft taldcroft is a code owner
@neutrinoceros neutrinoceros Awaiting requested review from neutrinoceros neutrinoceros will be requested when the pull request is marked ready for review neutrinoceros is a code owner

Assignees

No one assigned

Labels

installation table utils whatsnew-needed

Projects

None yet

Milestone

v7.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@TheSkyentist @pllim