Skip to content

Backport PR #18358 on branch v7.1.x (style(cosmo): unstringify annotations) - #18383

Merged
eerovaher merged 1 commit into
astropy:v7.1.xfrom
nstarman:auto-backport-of-pr-18358-on-v7.1.x
Jul 3, 2025
Merged

eerovaher merged 1 commit into
astropy:v7.1.xfrom
nstarman:auto-backport-of-pr-18358-on-v7.1.x

Conversation

@nstarman

@nstarman nstarman commented Jul 2, 2025 •

Copy link
Copy Markdown
Member

(cherry picked from commit 7f3ed7c)
Signed-off-by: nstarman [email protected]

(cherry picked from commit 7f3ed7c)
Signed-off-by: nstarman <[email protected]>

# Conflicts:
#	astropy/cosmology/units.py
@github-actions

github-actions Bot commented Jul 2, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

github-actions Bot commented Jul 2, 2025

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@nstarman
nstarman marked this pull request as ready for review July 2, 2025 18:58
@nstarman
nstarman requested a review from a team as a code owner July 2, 2025 18:59
@nstarman nstarman moved this from Triage to In Progress in Cosmology, the Expansion Jul 2, 2025
@pllim pllim added skip-basebranch-check Skip base branch check for direct backports Manual Backport labels Jul 2, 2025
@pllim

pllim commented Jul 2, 2025

Copy link
Copy Markdown
Member

close/reopen to retrigger CI

@pllim pllim closed this Jul 2, 2025
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Cosmology, the Expansion Jul 2, 2025
@pllim pllim reopened this Jul 2, 2025
@github-project-automation github-project-automation Bot moved this from Done to In Progress in Cosmology, the Expansion Jul 2, 2025
@pllim
pllim requested a review from eerovaher July 2, 2025 19:02
@nstarman nstarman closed this Jul 2, 2025
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Cosmology, the Expansion Jul 2, 2025
@nstarman nstarman reopened this Jul 2, 2025
@github-project-automation github-project-automation Bot moved this from Done to In Progress in Cosmology, the Expansion Jul 2, 2025
@pllim

pllim commented Jul 2, 2025

Copy link
Copy Markdown
Member

I think the RTD status will update itself when it is less confused.

p.s. I already did the close/reopen... 😆

@pllim

pllim commented Jul 2, 2025

Copy link
Copy Markdown
Member

I am not familiar with the code, so I will defer review to @eerovaher . Thanks!

@eerovaher eerovaher added typing related to type annotations backport-v7.1.x and removed skip-basebranch-check Skip base branch check for direct backports labels Jul 3, 2025
@github-project-automation github-project-automation Bot moved this from In Progress to Reviewer approved in Cosmology, the Expansion Jul 3, 2025
@eerovaher
eerovaher merged commit 0b24843 into astropy:v7.1.x Jul 3, 2025
@github-project-automation github-project-automation Bot moved this from Reviewer approved to Done in Cosmology, the Expansion Jul 3, 2025
@nstarman
nstarman deleted the auto-backport-of-pr-18358-on-v7.1.x branch July 3, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants