Skip to content

Backport PR #18381 on v7.1.x (TST: Add Sersic2D to NON_FINITE_LM_MODELS) - #18382

Merged
pllim merged 1 commit into
astropy:v7.1.xfrom
neutrinoceros:bp/18381
Jul 2, 2025
Merged

pllim merged 1 commit into
astropy:v7.1.xfrom
neutrinoceros:bp/18381

Conversation

@neutrinoceros

Copy link
Copy Markdown
Contributor

Description

Manual backport for #18381
cherry picked from commit 7ee167b

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions

github-actions Bot commented Jul 2, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

github-actions Bot commented Jul 2, 2025

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@neutrinoceros neutrinoceros added the skip-basebranch-check Skip base branch check for direct backports label Jul 2, 2025
…E_LM_MODELS)

(cherry picked from commit 7ee167b)
@neutrinoceros
neutrinoceros marked this pull request as ready for review July 2, 2025 14:37
@neutrinoceros
neutrinoceros requested a review from a team as a code owner July 2, 2025 14:37

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pllim

pllim commented Jul 2, 2025

Copy link
Copy Markdown
Member

There was problem with Ubuntu cloud thingy. I think resolved now.

@pllim

pllim commented Jul 2, 2025

Copy link
Copy Markdown
Member

Eh, py311-test-image-mpldev-cov should not be required... Lemme update the branch rule.

@pllim
pllim merged commit 4ca8bbe into astropy:v7.1.x Jul 2, 2025
@neutrinoceros
neutrinoceros deleted the bp/18381 branch July 2, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants