Repository navigation
TST: Add Sersic2D to NON_FINITE_LM_MODELS - #18381
Conversation
in modeling tests and undo scipy max pin for Windows.
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
neutrinoceros
left a comment
There was a problem hiding this comment.
CI is happy, so I have nothing to complain about, but I don't know if this fix is correct. I would still like package maintainers to weigh in.
|
Alright then, let's roll with it. Thanks @WilliamJamieson |
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
|
I'll backport this manually |
…E_LM_MODELS) (cherry picked from commit 7ee167b)
|
backport at #18382 |
…E_LM_MODELS) (cherry picked from commit 7ee167b)
|
Thanks, all! |
Backport PR #18381 on `v7.1.x` (TST: Add Sersic2D to NON_FINITE_LM_MODELS)
Description
This pull request is to add
Sersic2DtoNON_FINITE_LM_MODELSin modeling tests and undoscipymax pin for Windows.jplephemtest case for newer versions #18331