Repository navigation
Matter density as a trait - #18307
Conversation
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
|
@nstarman would you want me to move dark matter density and other related traits into this single class. I am happy to do that. I figured matter density was a good one to tackle before touching the energy densities. |
nstarman
left a comment
There was a problem hiding this comment.
Thanks @preshanth for the PR! Some comments.
|
I was wondering what you thought about having all the matter densities in one class. Include the dark matter here too. |
|
I ask because I can compute dark matter density as matter - baryons and I can do that inside the MatterDensity class rather than have a separate one. I have nominally made a separate branch and moved the dark matter there too. I have moved the functions. If we agree on what formats. I am happy to do photon and dark energy along with distance measures next. I will leave the neutrinos to you. |
nstarman
left a comment
There was a problem hiding this comment.
This is looking really close. I haven't had time yet for a full review. This is a short comment.
I think it's best to keep them separate. We want to use these traits to build e.g. |
nstarman
left a comment
There was a problem hiding this comment.
Thanks @preshanth. This looks great.
Description
This pull request is to address the creation of a matter density trait. The goal here is to allow pedagogical models.
Fixes a part of #17150