Repository navigation
Conversation
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
|
Hi humans 👋 - this pull request hasn't had any new commits for approximately 4 months. I plan to close this in 30 days if the pull request doesn't have any new commits by then. In lieu of a stalled pull request, please consider closing this and open an issue instead if a reminder is needed to revisit in the future. Maintainers may also choose to add keep-open label to keep this PR open but it is discouraged unless absolutely necessary. If this PR still needs to be reviewed, as an author, you can rebase it to reset the clock. If you believe I commented on this pull request incorrectly, please report this here. |
|
@pllim - wasnt' the bot supposed to come and complain after 5 months rather than 4? |
|
We had discussion about this at the interop, so I expect that code and implementation of the decisions will be made in the coming month. So with that, I put the keep-open label on to keep this alive for at least another half year. |
|
Well, I had to define it in seconds, so the human month is approximate and can be 4 or 5 because of uneven months and so on. |
This comment was marked as resolved.
This comment was marked as resolved.
|
On Mon, Aug 24, 2026 at 08:14:36AM -0700, P. L. Lim wrote:
pllim left a comment (astropy/astropy#18294)
Will this be revisited in the next IVOA Interop?
This is still under review; the review cycles are not usually aligned
with the Interops, though.
There is a working draft of VOTable that allows utf-8 chars,
<https://ivoa.net/Documents/VOTable/20260413/WD-VOTable-1.6-20260413.html>;
this has a few more intricacies, mainly with multidimensional char
arrays (which need to split by utf-8-encoding in case you already
have decoded input, as, e.g., when you receive TABLEDATA).
I'd suggest we wait until VOTable 1.6 is a Proposed Recommendation,
which is the IVOA's way to say: "This is what it'll be unless we've
really messed up, so go forth and implement". I'd roughly say
"probably this year" as to the time frame.
|
|
Hi humans 👋 - this pull request hasn't had any new commits for approximately 1 year, 4 months. I plan to close this in a month if the pull request doesn't have any new commits by then. In lieu of a stalled pull request, please consider closing this and open an issue instead if a reminder is needed to revisit in the future. Maintainers may also choose to add keep-open label to keep this PR open but it is discouraged unless absolutely necessary. If this PR still needs to be reviewed, as an author, you can rebase it to reset the clock. If you believe I commented on this pull request incorrectly, please report this here. |
|
@pllim - the bot's comment needs to be updated now that the label is gone. Otherwise, this PR needs a rebase as we want to keep it open as atypical case where upstream is a blocker for merging. |
This would be necessary once we prototype the interpretation of char as utf-8 sequence. Apologies for just dumping in a bunch of doctests and possibly ignoring all kinds of style guides; if nobody else volunteers to clean this up, I'll take another dive into the astropy tooling once I've pulled my development machine to trixie.
5c3dde5 to
b90f66f
Compare
|
On Thu, Oct 15, 2026 at 10:57:46PM -0700, Brigitta Sipőcz wrote:
bsipocz left a comment (astropy/astropy#18294)
Otherwise, this PR needs a rebase as we want to keep it open as
atypical case where upstream is a blocker for merging.
Did the rebase.
In general, I'm rather sure the VOTable update that needs that
(interpret char arrays as utf-8) is now stable, and it would actually
be great if we provided a reference implementation (TOPCAT/stilts can
do this already, so we have something to try against). Regrettably,
I won't find time to do this right (there are subtleties with char
arrays) any time soon. Perhaps someone else can step in?
|
Oh yeah, good catch! I will do that as a separate PR (#20629). |
|
p.s. I tentatively added a milestone just so you have one less failing check. When you know for sure, feel free to update it. |
|
@msdemlei - I tried but unfortunately cannot push to/rebase the branch as it's opened from the GAVO org account rather than from a personal one. |
Description
This function would be necessary once we prototype the interpretation of char as utf-8 sequences, which in turn has been discussed at the College Park Interop and in ivoa-std/VOTable#55.
Discussion
Apologies for the state this is in and that it will probably fail all kinds of CI; if nobody else volunteers, I will clean it up (including moving the doctests to pytest) once we actually do serialise utf-8 into chars. Until then, can this be a draft?