cosmo: Hubble parameter trait by preshanth · Pull Request #18271 · astropy/astropy

preshanth · 2025-06-13T21:42:41Z

Description

This pull request is to address the introduction of hubble parameter as a trait in the FLRW cosmology class.

Fixes a portion of #17150

By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

github-actions · 2025-06-13T21:43:11Z

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

Do the proposed changes actually accomplish desired goals?
Do the proposed changes follow the Astropy coding guidelines?
Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

preshanth · 2025-06-13T21:43:38Z

@nstarman Have a look at this when you get a chance.

preshanth · 2025-06-13T22:31:26Z

I will fix the tests first tonight

nstarman

Thanks @preshanth!
I think starting with _HubbleParameter as a private class is the right way to start.

preshanth · 2025-06-17T13:52:41Z

@nstarman I think this covers yours suggestions. If you are fine with it I will push some edits for the docs and then this can be converted from draft to PR.

…ation in docs

preshanth · 2025-06-17T16:42:53Z

@nstarman I can pick up the next one now that I am warmed up and if you are happy with this.

nstarman

@preshanth I think this PR is close. The H method needs to be removed from FLRW so that it uses the HubbleParameter.H method that it inherits.

preshanth · 2025-06-21T03:00:36Z

I wonder if we have to add tests directly using traits to ensure that the code coverage does not drop.

preshanth · 2025-06-21T04:37:57Z

Sorry this is taking forever. Its a good template for me. Thanks for your efforts @nstarman

nstarman · 2025-06-26T00:51:08Z

@preshanth the CI is picking up an issue in the docs.

_____________________________ [doctest] traits.rst _____________________________
[gw3] linux -- Python 3.11.13 /home/runner/work/astropy/astropy/.tox/py311-test-double/bin/python3
037 ...
038 ...     is_flat = False
039 ...     # Additional custom methods and properties can be added here
040 
041 >>> cosmo = CustomCosmology(H0=70, Om0=0.3, Ode0=0.7)
042 >>> cosmo.H0
043 <Quantity 70. km / (Mpc s)>
044 >>> cosmo.scale_factor(0)
045 <Quantity 1.>
046 >>> cosmo.Tcmb(1)
Expected:
    <Quantity 5.45>
Got:
    <Quantity 5.45 K>

/home/runner/work/astropy/astropy/docs/cosmology/traits.rst:46: DocTestFailure
______________________________ [doctest] 7.2.rst _______________________________
[gw3] linux -- Python 3.11.13 /home/runner/work/astropy/astropy/.tox/py311-test-double/bin/python3
058 ...
059 ...     is_flat = False
060 ...     # Additional custom methods and properties can be added here
061 
062 >>> cosmo = CustomCosmology(H0=70, Om0=0.3, Ode0=0.7)
063 >>> cosmo.H0
064 <Quantity 70. km / (Mpc s)>
065 >>> cosmo.scale_factor(0)
066 <Quantity 1.>
067 >>> cosmo.Tcmb(1)
Expected:
    <Quantity 5.45>
Got:
    <Quantity 5.45 K>

/home/runner/work/astropy/astropy/docs/whatsnew/7.2.rst:67: DocTestFailure
_____________________________ [doctest] traits.rst _____________________________
[gw0] linux -- Python 3.11.13 /home/runner/work/astropy/astropy/.tox/py311-test-double/bin/python3
037 ...
038 ...     is_flat = False
039 ...     # Additional custom methods and properties can be added here
040 
041 >>> cosmo = CustomCosmology(H0=70, Om0=0.3, Ode0=0.7)
042 >>> cosmo.H0
043 <Quantity 70. km / (Mpc s)>
044 >>> cosmo.scale_factor(0)
045 <Quantity 1.>
046 >>> cosmo.Tcmb(1)
Expected:
    <Quantity 5.45>
Got:
    <Quantity 5.45 K>

/home/runner/work/astropy/astropy/docs/cosmology/traits.rst:46: DocTestFailure
______________________________ [doctest] 7.2.rst _______________________________
[gw3] linux -- Python 3.11.13 /home/runner/work/astropy/astropy/.tox/py311-test-double/bin/python3
058 ...
059 ...     is_flat = False
060 ...     # Additional custom methods and properties can be added here
061 
062 >>> cosmo = CustomCosmology(H0=70, Om0=0.3, Ode0=0.7)
063 >>> cosmo.H0
064 <Quantity 70. km / (Mpc s)>
065 >>> cosmo.scale_factor(0)
066 <Quantity 1.>
067 >>> cosmo.Tcmb(1)
Expected:
    <Quantity 5.45>
Got:
    <Quantity 5.45 K>

preshanth · 2025-06-26T00:55:24Z

On it.

nstarman · 2025-06-26T01:23:09Z

@preshanth because of squash-merging it's not a big deal, but in general we prefer to do rebasing rather than merging to update a PR, e.g. c426c39. Just a PSA :).

preshanth · 2025-06-26T01:29:25Z

@preshanth because of squash-merging it's not a big deal, but in general we prefer to do rebasing rather than merging to update a PR, e.g. c426c39. Just a PSA :).

This makes my master diverge from the main right. That throws me off. I can give it a shot next time.

nstarman · 2025-06-26T01:41:00Z

One more docs failure. Same thing in 7.2.rst

preshanth · 2025-06-26T02:02:14Z

@nstarman I finally got all the docs right. The rest should pass.

nstarman

Thanks @preshanth for the PR! Looks great. Let's get this in.

Initial commit for hubble parameter trait

e181cd1

preshanth requested a review from a team as a code owner June 13, 2025 21:42

preshanth requested a review from nstarman June 13, 2025 21:42

github-actions Bot added the cosmology label Jun 13, 2025

github-project-automation Bot moved this to Triage in Cosmology, the Expansion Jun 13, 2025

github-project-automation Bot added this to Cosmology, the Expansion Jun 13, 2025

preshanth marked this pull request as draft June 13, 2025 21:59

nstarman reviewed Jun 14, 2025

View reviewed changes

Comment thread astropy/cosmology/_src/flrw/base.py Resolved

Comment thread astropy/cosmology/_src/traits/hubble.py Resolved

Comment thread astropy/cosmology/_src/traits/hubble.py Resolved

preshanth added 2 commits June 17, 2025 07:15

Fixing tests and incorporating PR suggestions

e02a083

Merge branch 'main' into cosmo-Hubbleparameter

0ff97e0

pllim added this to the v7.2.0 milestone Jun 17, 2025

nstarman changed the title ~~Initial commit for hubble parameter trait~~ cosmo: Hubble parameter trait Jun 17, 2025

nstarman reviewed Jun 17, 2025

View reviewed changes

Comment thread astropy/cosmology/_src/flrw/base.py Resolved

nstarman reviewed Jun 17, 2025

View reviewed changes

Comment thread astropy/cosmology/_src/traits/hubble.py Resolved

nstarman moved this from Triage to In Progress in Cosmology, the Expansion Jun 17, 2025

Updated to remove commented out unit conversions and add trait inform…

5d3ce88

…ation in docs

nstarman reviewed Jun 17, 2025

View reviewed changes

Comment thread docs/cosmology/traits.rst Resolved

Included a changes entry and reverted the docs entry for private class.

b427361

preshanth marked this pull request as ready for review June 17, 2025 16:36

nstarman added the no-changelog-entry-needed label Jun 19, 2025

nstarman requested changes Jun 19, 2025

View reviewed changes

github-project-automation Bot moved this from In Progress to Review in progress in Cosmology, the Expansion Jun 19, 2025

preshanth added 2 commits June 19, 2025 17:04

Updating to remove H function from base

c17fa00

Merge branch 'main' into cosmo-Hubbleparameter

c7902a6

preshanth requested a review from nstarman June 19, 2025 23:25

Updating docs

105b5d1

nstarman reviewed Jun 21, 2025

View reviewed changes

Comment thread docs/changes/cosmology/18271.feature.rst Resolved

Accepted doc changes

48a56b3

nstarman reviewed Jun 21, 2025

View reviewed changes

Comment thread docs/cosmology/traits.rst Resolved

Comment thread docs/cosmology/traits.rst Resolved

Comment thread docs/cosmology/traits.rst Resolved

Comment thread docs/whatsnew/7.2.rst Resolved

Comment thread docs/changes/cosmology/18271.feature.rst Resolved

Updated docs and traits.py to import HubbleParameter

05daaa2

nstarman reviewed Jun 21, 2025

View reviewed changes

Comment thread docs/cosmology/traits.rst Resolved

nstarman reviewed Jun 21, 2025

View reviewed changes

Comment thread docs/cosmology/traits.rst Resolved

preshanth added 2 commits June 20, 2025 22:27

Incorporating comments

0fce50c

Moved it to its own section and talking about HubbleParameter

b58d927

nstarman removed the no-changelog-entry-needed label Jun 21, 2025

preshanth added 2 commits June 25, 2025 19:16

Merge branch 'main' into cosmo-Hubbleparameter

c426c39

Added the missing kelvin symbol in the failing docs

ea7a323

Fixing the failing docs

4e37362

preshanth added 2 commits June 25, 2025 19:45

Fixing 7.2.rst

707e00d

Fixing hubble time in docs

d2a0414

Fixing missing = in 7.2.rst

6deaa64

nstarman approved these changes Jun 26, 2025

View reviewed changes

github-project-automation Bot moved this from Review in progress to Reviewer approved in Cosmology, the Expansion Jun 26, 2025

nstarman merged commit 9d15746 into astropy:main Jun 26, 2025

github-project-automation Bot moved this from Reviewer approved to Done in Cosmology, the Expansion Jun 26, 2025

preshanth deleted the cosmo-Hubbleparameter branch June 26, 2025 04:09

nstarman mentioned this pull request Oct 23, 2025

Towards Pedagogical Cosmological Models #17150

Open

12 of 22 tasks

Conversation

preshanth commented Jun 13, 2025

Description

Uh oh!

github-actions Bot commented Jun 13, 2025

Uh oh!

preshanth commented Jun 13, 2025

Uh oh!

preshanth commented Jun 13, 2025

Uh oh!

nstarman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

preshanth commented Jun 17, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

preshanth commented Jun 17, 2025

Uh oh!

nstarman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

preshanth commented Jun 21, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

preshanth commented Jun 21, 2025

Uh oh!

nstarman commented Jun 26, 2025

Uh oh!

preshanth commented Jun 26, 2025

Uh oh!

nstarman commented Jun 26, 2025

Uh oh!

preshanth commented Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nstarman commented Jun 26, 2025

Uh oh!

preshanth commented Jun 26, 2025

Uh oh!

nstarman left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

preshanth commented Jun 26, 2025 •

edited

Loading