Skip to content

fix: unicodechar fields can have bounded variable size - #18075

Merged
bsipocz merged 1 commit into
astropy:mainfrom
ManonMarchand:fix-variable-size-unicodechar-fields
Apr 30, 2025
Merged

fix: unicodechar fields can have bounded variable size#18075
bsipocz merged 1 commit into
astropy:mainfrom
ManonMarchand:fix-variable-size-unicodechar-fields

Conversation

@ManonMarchand

@ManonMarchand ManonMarchand commented Apr 30, 2025

Copy link
Copy Markdown
Member

Hi astropy maintainers 🙂

Description

This PR is a fix for unicodeChar fields in VOTables. Currently, their arraysize can only be fixed (arraysize is an int) or variable (araysize="*"). But it should also be allowed to be of bounded variable size (arraysize="20*" means a string with 0 to 20 characters).

This is already working for char fields, so I just coppied the class above.

I checked the standard, and other VOTable linters to be sure that this is indeed a bug from astropy.

Before the fix

from astropy.io.votable import tree
field = tree.Field(None, name="unicode", datatype="unicodeChar", arraysize="20*")
astropy.io.votable.exceptions.E01: ?:?:?: E01: Invalid size specifier '20*' for a unicode field (in field 'unicode')

And there's no error raised anymore after the fix.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions

github-actions Bot commented Apr 30, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@ManonMarchand
ManonMarchand force-pushed the fix-variable-size-unicodechar-fields branch from 240b26a to 5f18e83 Compare April 30, 2025 08:28
@pllim pllim added this to the v7.0.2 milestone Apr 30, 2025
bsipocz
bsipocz approved these changes Apr 30, 2025
View reviewed changes

@bsipocz bsipocz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this looks all great!

@bsipocz
bsipocz merged commit f63992c into astropy:main Apr 30, 2025
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Apr 30, 2025
@bsipocz @meeseeksmachine
Backport PR astropy#18075: fix: unicodechar fields can have bounded v…
5ec434e 
…ariable size
@meeseeksmachine meeseeksmachine mentioned this pull request Apr 30, 2025
Merged
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Apr 30, 2025
@bsipocz @meeseeksmachine
Backport PR astropy#18075: fix: unicodechar fields can have bounded v…
14a7587 
…ariable size
@meeseeksmachine meeseeksmachine mentioned this pull request Apr 30, 2025
Merged
bsipocz added a commit that referenced this pull request Apr 30, 2025
@bsipocz
Merge pull request #18079 from meeseeksmachine/auto-backport-of-pr-18…
790eba7 
…075-on-v7.0.x

Backport PR #18075 on branch v7.0.x (fix: unicodechar fields can have bounded variable size)
bsipocz added a commit that referenced this pull request Apr 30, 2025
@bsipocz
Merge pull request #18080 from meeseeksmachine/auto-backport-of-pr-18…
4fb1d7b 
…075-on-v7.1.x

Backport PR #18075 on branch v7.1.x (fix: unicodechar fields can have bounded variable size)
@pllim pllim mentioned this pull request May 5, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bsipocz bsipocz bsipocz approved these changes

Assignees

No one assigned

Labels

Bug io.votable

Projects

None yet

Milestone

v7.0.2

Development

Successfully merging this pull request may close these issues.

3 participants

@ManonMarchand @bsipocz @pllim