Repository navigation
API: Rename showtable to showtable-astropy - #18047
Conversation
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
|
👋 Thank you for your draft pull request! Do you know that you can use |
|
Should stay in draft until |
|
Any reasons why this have to stay on dev for another half year? I mean it's not like there will be a deprecation period, so users won't be able to pick up on this gracefully |
|
Hmm I thought we said we can only break API on |
|
ahh, ok, fair enough |
olebole
left a comment
There was a problem hiding this comment.
For me this is fine, approving.
Concerning deprecation: one could still have a showtable script for a while that prints a deprecation message and then runs showtable-astropy, but I am not sure whether this is worth the effort.
Agreed, we should have a deprecation message. I think an easy way is by defining a new function in Then: |
|
Having a deprecation command would be good, and pretty easy to do as @taldcroft suggests. Can we get this in before feature freeze @pllim? |
|
OK I can work on that. Thanks for the suggestions! |
033f8d8 to
049b577
Compare
|
Okay, I deprecated showtable and updated milestone, as suggested. With current state of the PR, it would be lie this: |
|
devdeps failure is unrelated |
|
Thanks for the quick reviews! |
Description
This pull request is to fix #7233
I don't think it is possible to deprecate a command line? So should we just YOLO this one?