Skip to content

fix ruff rule B007 violation in astropy/samp - #17881

Merged
neutrinoceros merged 1 commit into
astropy:mainfrom
kangqiwang:ruff-b007/samp
Mar 17, 2025
Merged

neutrinoceros merged 1 commit into
astropy:mainfrom
kangqiwang:ruff-b007/samp

Conversation

@kangqiwang

Copy link
Copy Markdown
Contributor

Description

This pull request is to address to split pull request #17844 , and it ensure compliance of astropy/coordinates Ruff rule unused-loop-control-variable (B007)

Fixes partially #14818

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@eerovaher eerovaher mentioned this pull request Mar 12, 2025
3 of 6 tasks
@pllim pllim added this to the v7.1.0 milestone Mar 12, 2025
Comment thread .ruff.toml Resolved
@kangqiwang
kangqiwang force-pushed the ruff-b007/samp branch 2 times, most recently from 6df5f1a to 24d6cfc Compare March 17, 2025 14:34
@neutrinoceros

Copy link
Copy Markdown
Contributor

I'll fix fix merge conflicts now.

@neutrinoceros
neutrinoceros enabled auto-merge March 17, 2025 16:06
@neutrinoceros
neutrinoceros merged commit 6f10504 into astropy:main Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants