Repository navigation
fix ruff rule B007 violation in astropy/modeling - #17860
Merged
Merged
Conversation
kangqiwang
requested review from
a team,
WilliamJamieson and
nstarman
as code owners
March 6, 2025 17:12
Contributor
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
pllim
reviewed
Mar 6, 2025
Comment on lines
+1016
to
+1017
| for i in range(1, self.niter + 1): | ||
| n=i |
nstarman
reviewed
Mar 6, 2025
Member
|
Thanks for the PR @kangqiwang. There are sone good opportunities to further simplify the code. |
Comment on lines
+1016
to
+1017
| for i in range(1, self.niter + 1): | ||
| n=i |
Contributor
There was a problem hiding this comment.
shouldn't this be
Suggested change
| for i in range(1, self.niter + 1): | |
| n=i | |
| for _ in range(1, self.niter + 1): |
?
Member
There was a problem hiding this comment.
The numbers of loops executed is recorded and there is a possibility of breaking early, but you have to go all the way down to line 1109 (or 1108 in main) to see that. I would rename n to niter and replace
Suggested change
| for i in range(1, self.niter + 1): | |
| n=i | |
| for _ in range(self.niter): | |
| niter += 1 |
Then it would be clearer that niter is a counter that will be used after the loop, not just a loop variable.
3 of 6 tasks
neutrinoceros
force-pushed
the
ruff-b007/modeling
branch
from
March 17, 2025 16:12
5d79957 to
dfeaa97
Compare
Contributor
|
I fixed formatting issues and a (spurious) merge conflict. Let's get this in. Thanks @kangqiwang |
neutrinoceros
approved these changes
Mar 17, 2025
neutrinoceros
enabled auto-merge
March 17, 2025 16:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request is to address to split pull request #17844 , and it ensure compliance of
astropy/modelingto Ruff rule unused-loop-control-variable (B007)fixes partially #14818
Fixes #