[pre-commit.ci] pre-commit autoupdate#17841
Closed
pre-commit-ci[bot] wants to merge 2 commits intomainfrom
Closed
Conversation
updates: - [github.com/woodruffw/zizmor-pre-commit: v1.3.0 → v1.4.1](zizmorcore/zizmor-pre-commit@v1.3.0...v1.4.1) - [github.com/astral-sh/ruff-pre-commit: v0.8.6 → v0.9.9](astral-sh/ruff-pre-commit@v0.8.6...v0.9.9)
pre-commit-ci
bot
requested review from
WilliamJamieson and
nstarman
as code owners
github-actions
bot
added
testing
skip-changelog-checks
Contributor
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
pre-commit-ci
bot
requested review from
a team,
dhomeier,
mcara,
saimn and
taldcroft
as code owners
eerovaher
reviewed
Mar 3, 2025
Member
eerovaher
left a comment
eerovaher
left a comment
There was a problem hiding this comment.
Ruff formatter is making quite a lot of changes to assert statements with custom error messages. I suspect that in many cases the custom messages are not any better than the messages pytest could generate automatically. But looking into that properly would go beyond the scope of this pull request.
| tform = compressed_coldefs[column_name].format | ||
| if tform.startswith("1"): | ||
| tform = tform[1:] | ||
| tform = tform.removeprefix("1") |
| keyword = keyword.strip().upper() | ||
| if keyword.startswith("HIERARCH "): | ||
| keyword = keyword[9:] | ||
| keyword = keyword.removeprefix("HIERARCH ") |
nstarman
approved these changes
Mar 3, 2025
Member
nstarman
left a comment
nstarman
left a comment
There was a problem hiding this comment.
See @eerovaher comments, otherwise looks good. All string cleanup.
Member
|
Not sure about merging with unresolved comments in #17619 . Should we just close this without merge and wait for manual resolution? |
1 task
Member
|
Or even the same round of auto fix, suggested next month. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updates: