TST: Re-enable test_all for devdeps but only when noscipy is not specified (try 2) - #17837

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

• Do the proposed changes actually accomplish desired goals?
• Do the proposed changes follow the Astropy coding guidelines?
• Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
• Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
• Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
• Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
• Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
• Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
• At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

How come skyfield is not install even when it is defined in test_all? Any idea, @neutrinoceros ?

Unfortunately no, it's a mystery to me too. I'd be inclined to report this as a bug in tox though: if the current behavior is expected, it should at least not happen silently.

Maybe this? 🤔

tox-dev/tox#3433

Has test_all ever worked? 🤯

I'm slightly confused. What seems to be broken at the moment ?
I see a couple cancelled jobs which I assume you stopped manually, but didn't produce any failure I can see before that, and the remaining failure on link check looks unrelated (but is it ?)

I was expecting pandas and skyfield to get installed into devdeps but they are not.

Oh right, sorry, this was clear from the rest of the conversation ! Context switching will be the death of me.
Welp, test_all works as much as any extra, as far as I can tell. I'm now pretty convinced that you indeed found the correct bug report on tox's issue tracker...

We cannot just sit around to wait for upstream since no fix is in place yet there. Do we have to refactor pyproject.toml or decouple tox deps from optional dependencies there? 😒

it might be worth trying to use a PEP 775 dependency group, which tox supposedly supports, though I guess it cannot replace the extra just yet (see #17623)... so that would mean (temporary) duplication ?

I will close this one because I want to keep the diff where it is easy to find in the future. Because ideally, the fix should be something like this but it is currently not working due to upstream. I will think hackier and open try 3.